From: David Miller <davem@davemloft.net>
To: mika.westerberg@linux.intel.com
Cc: davidx.m.ertman@intel.com, aaron.f.brown@intel.com,
jeffrey.t.kirsher@intel.com, bruce.w.allan@intel.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] e1000e: Fix compilation warning when !CONFIG_PM_SLEEP
Date: Thu, 16 Jan 2014 15:36:50 -0800 (PST) [thread overview]
Message-ID: <20140116.153650.1123366219148240100.davem@davemloft.net> (raw)
In-Reply-To: <1389875979-30340-1-git-send-email-mika.westerberg@linux.intel.com>
From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: Thu, 16 Jan 2014 14:39:39 +0200
> Commit 7509963c703b (e1000e: Fix a compile flag mis-match for
> suspend/resume) moved suspend and resume hooks to be available when
> CONFIG_PM is set. However, it can be set even if CONFIG_PM_SLEEP is not set
> causing following warnings to be emitted:
>
> drivers/net/ethernet/intel/e1000e/netdev.c:6178:12: warning:
> ‘e1000_suspend’ defined but not used [-Wunused-function]
>
> drivers/net/ethernet/intel/e1000e/netdev.c:6185:12: warning:
> ‘e1000_resume’ defined but not used [-Wunused-function]
>
> To fix this make the hooks to be available only when CONFIG_PM_SLEEP is set
> and remove CONFIG_PM wrapping from driver ops because this is already
> handled by SET_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS().
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied, thanks.
prev parent reply other threads:[~2014-01-16 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 12:39 [PATCH] e1000e: Fix compilation warning when !CONFIG_PM_SLEEP Mika Westerberg
2014-01-16 23:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116.153650.1123366219148240100.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aaron.f.brown@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=davidx.m.ertman@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox