From: David Miller <davem@davemloft.net>
To: pebolle@tiscali.nl
Cc: ogerlitz@mellanox.com, jackm@dev.mellanox.co.il,
ronye@mellanox.com, hadarh@mellanox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] net/mlx4_core: clean up cq_res_start_move_to()
Date: Thu, 16 Jan 2014 16:05:05 -0800 (PST) [thread overview]
Message-ID: <20140116.160505.2018103158475655301.davem@davemloft.net> (raw)
In-Reply-To: <1389728736.28068.8.camel@x220>
From: Paul Bolle <pebolle@tiscali.nl>
Date: Tue, 14 Jan 2014 20:45:36 +0100
> Building resource_tracker.o triggers a GCC warning:
> drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function 'mlx4_HW2SW_CQ_wrapper':
> drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:3019:16: warning: 'cq' may be used uninitialized in this function [-Wmaybe-uninitialized]
> atomic_dec(&cq->mtt->ref_count);
> ^
>
> This is a false positive. But a cleanup of cq_res_start_move_to() can
> help GCC here. The code currently uses a switch statement where an
> if/else construct would do too, since only two of the switch's four
> cases can ever occur. Dropping that switch makes the warning go away.
>
> While we're at it, add some missing braces.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Applied.
prev parent reply other threads:[~2014-01-17 0:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 13:01 [PATCH 1/2] net/mlx4_core: clean up cq_res_start_move_to() Paul Bolle
2014-01-08 11:18 ` Or Gerlitz
2014-01-14 6:47 ` Jack Morgenstein
2014-01-14 11:23 ` Paul Bolle
2014-01-14 19:45 ` [PATCH v2 " Paul Bolle
2014-01-15 23:12 ` David Miller
2014-01-16 7:46 ` Jack Morgenstein
2014-01-16 19:39 ` David Miller
2014-01-17 0:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116.160505.2018103158475655301.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jackm@dev.mellanox.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=pebolle@tiscali.nl \
--cc=ronye@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).