From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Daniel Borkmann <dborkman@redhat.com>,
netdev <netdev@vger.kernel.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH net-next] ipv6: send Change Status Report after DAD is completed
Date: Thu, 16 Jan 2014 13:24:09 +0100 [thread overview]
Message-ID: <20140116122409.GC7436@order.stressinduktion.org> (raw)
In-Reply-To: <20140116122154.GK5359@plex.lan>
On Thu, Jan 16, 2014 at 10:21:54AM -0200, Flavio Leitner wrote:
> > >diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
> > >index 99cd65c..8ac17f5 100644
> > >--- a/net/ipv6/mcast.c
> > >+++ b/net/ipv6/mcast.c
> > >@@ -1493,7 +1493,7 @@ static struct sk_buff *add_grhead(struct sk_buff *skb, struct ifmcaddr6 *pmc,
> > > skb_tailroom(skb)) : 0)
> > >
> > > static struct sk_buff *add_grec(struct sk_buff *skb, struct ifmcaddr6 *pmc,
> > >- int type, int gdeleted, int sdeleted)
> > >+ int type, int gdeleted, int sdeleted, int crsend)
> >
> > Maybe we should convert the last three to 'bool' at some point in time?
>
> I'd say so.
Maybe it works out those can be one enum with a specified operation and no
bool vector?
Maybe you could have a look?
Thanks,
Hannes
prev parent reply other threads:[~2014-01-16 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 19:10 [PATCH net-next] ipv6: send Change Status Report after DAD is completed Flavio Leitner
2014-01-16 11:21 ` Daniel Borkmann
2014-01-16 12:21 ` Flavio Leitner
2014-01-16 12:24 ` Hannes Frederic Sowa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116122409.GC7436@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).