From: Flavio Leitner <fbl@redhat.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: simplify detection of first operational link-local address on interface
Date: Thu, 16 Jan 2014 19:20:32 -0200 [thread overview]
Message-ID: <20140116212032.GP5359@plex.lan> (raw)
In-Reply-To: <20140116191304.GC17529@order.stressinduktion.org>
On Thu, Jan 16, 2014 at 08:13:04PM +0100, Hannes Frederic Sowa wrote:
> In commit 1ec047eb4751e3 ("ipv6: introduce per-interface counter for
> dad-completed ipv6 addresses") I build the detection of the first
> operational link-local address much to complex. Additionally this code
> now has a race condition.
>
> Replace it with a much simpler variant, which just scans the address
> list when duplicate address detection completes, to check if this is
> the first valid link local address and send RS and MLD reports then.
>
> Fixes: 1ec047eb4751e3 ("ipv6: introduce per-interface counter for dad-completed ipv6 addresses")
> Reported-by: Jiri Pirko <jiri@resnulli.us>
> Cc: Flavio Leitner <fbl@redhat.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> ---
Nice
Acked-by: Flavio Leitner <fbl@redhat.com>
next prev parent reply other threads:[~2014-01-16 21:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 13:53 ipv6 addrconfg warn_on hit: WARN_ON(ifp->idev->valid_ll_addr_cnt < 0); Jiri Pirko
2014-01-16 14:07 ` Jiri Pirko
2014-01-16 14:38 ` Hannes Frederic Sowa
2014-01-16 15:18 ` Hannes Frederic Sowa
2014-01-16 17:27 ` Jiri Pirko
2014-01-16 17:31 ` Hannes Frederic Sowa
2014-01-16 19:13 ` [PATCH net] ipv6: simplify detection of first operational link-local address on interface Hannes Frederic Sowa
2014-01-16 20:15 ` Brian Haley
2014-01-16 20:27 ` Hannes Frederic Sowa
2014-01-16 21:20 ` Flavio Leitner [this message]
2014-01-16 21:47 ` Jiri Pirko
2014-01-18 2:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116212032.GP5359@plex.lan \
--to=fbl@redhat.com \
--cc=hannes@stressinduktion.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).