From: David Miller <davem@davemloft.net>
To: gerald.schaefer@de.ibm.com
Cc: davidshan@tencent.com, cl@linux.com,
venkat.x.venkatsubra@oracle.com, rds-devel@oss.oracle.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
schwidefsky@de.ibm.com, frank.blaschka@de.ibm.com,
sebott@linux.vnet.ibm.com
Subject: Re: [PATCH] net: rds: fix per-cpu helper usage
Date: Fri, 17 Jan 2014 17:52:59 -0800 (PST) [thread overview]
Message-ID: <20140117.175259.1030142896492431310.davem@davemloft.net> (raw)
In-Reply-To: <1389887688-55632-1-git-send-email-gerald.schaefer@de.ibm.com>
From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Date: Thu, 16 Jan 2014 16:54:48 +0100
> commit ae4b46e9d "net: rds: use this_cpu_* per-cpu helper" broke per-cpu
> handling for rds. chpfirst is the result of __this_cpu_read(), so it is
> an absolute pointer and not __percpu. Therefore, __this_cpu_write()
> should not operate on chpfirst, but rather on cache->percpu->first, just
> like __this_cpu_read() did before.
>
> Cc: <stable@vger.kernel.org> # 3.8+
> Signed-off-byd Gerald Schaefer <gerald.schaefer@de.ibm.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2014-01-18 1:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 15:54 [PATCH] net: rds: fix per-cpu helper usage Gerald Schaefer
2014-01-18 1:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140117.175259.1030142896492431310.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cl@linux.com \
--cc=davidshan@tencent.com \
--cc=frank.blaschka@de.ibm.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
--cc=venkat.x.venkatsubra@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox