From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] packet: fix a couple of cppcheck warnings
Date: Tue, 21 Jan 2014 16:52:03 -0800 (PST) [thread overview]
Message-ID: <20140121.165203.304954372532831580.davem@davemloft.net> (raw)
In-Reply-To: <1390128413-7075-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Sun, 19 Jan 2014 11:46:53 +0100
> Doesn't bring much, but also doesn't hurt us to fix 'em:
>
> 1) In tpacket_rcv() flush dcache page we can restirct the scope
> for start and end and remove one layer of indent.
>
> 2) In tpacket_destruct_skb() we can restirct the scope for ph.
>
> 3) In alloc_one_pg_vec_page() we can remove the NULL assignment
> and change spacing a bit.
>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2014-01-22 0:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 10:46 [PATCH net-next] packet: fix a couple of cppcheck warnings Daniel Borkmann
2014-01-22 0:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121.165203.304954372532831580.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox