netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bill Fink <billfink@mindspring.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: Fix some fallout from the etner_addr_copy() changes.
Date: Tue, 21 Jan 2014 23:23:31 -0500	[thread overview]
Message-ID: <20140121232331.130f34fc.billfink@mindspring.com> (raw)
In-Reply-To: <20140121.190348.1653034020095660800.davem@davemloft.net>

On Tue, 21 Jan 2014, David Miller wrote:

> net/appletalk/aarp.c: In function ‘__aarp_send_query’:
> net/appletalk/aarp.c:137:2: error: implicit declaration of function ‘ether_addr_copy’ [-Werror=implicit-function-declaration]
>  ...
> net/atm/lec.c: In function ‘send_to_lecd’:
> net/atm/lec.c:524:3: warning: passing argument 1 of ‘ether_addr_copy’ from incompatible pointer type [enabled by default]
> In file included from net/atm/lec.c:17:0:
> include/linux/etherdevice.h:227:20: note: expected ‘u8 *’ but argument is of type ‘unsigned char (*)[6]’
>  ...
> net/caif/caif_usb.c: In function ‘cfusbl_create’:
> net/caif/caif_usb.c:108:2: error: implicit declaration of function ‘ether_addr_copy’ [-Werror=implicit-function-declaration]
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
>  net/appletalk/aarp.c | 1 +
>  net/atm/lec.c        | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)

The commit message indicates problems with appletalk/aarp.c,
atm/lec.c, and caif/caif_usb.c, but the diffstat and patch only
address the first two and not caif/caif_usb.c.  Is that intended
or am I missing something.

					-Bill

  parent reply	other threads:[~2014-01-22  4:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-22  3:03 [PATCH] net: Fix some fallout from the etner_addr_copy() changes David Miller
2014-01-22  4:07 ` François-Xavier Le Bail
2014-01-22  4:23 ` Bill Fink [this message]
2014-01-22  6:54   ` David Miller
2014-01-22 22:56     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140121232331.130f34fc.billfink@mindspring.com \
    --to=billfink@mindspring.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).