From: Stephen Hemminger <stephen@networkplumber.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next v2 3/5] net_sched: act: move tcf_hashinfo_init() into tcf_register_action()
Date: Thu, 23 Jan 2014 16:08:59 -0800 [thread overview]
Message-ID: <20140123160859.147c6878@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1390516525-8556-4-git-send-email-xiyou.wangcong@gmail.com>
On Thu, 23 Jan 2014 14:35:23 -0800
Cong Wang <xiyou.wangcong@gmail.com> wrote:
>
> struct tc_action {
> void *priv;
> - const struct tc_action_ops *ops;
> + struct tc_action_ops *ops;
As much as possible all function tables should be constant.
One of the rootkit tricks is to overwrite a function table entry
at runtime. Granted tc action is a minor corner of the exposed
universe, but this seems a step backwards when the only real
gain is some refactoring/cleanup.
next prev parent reply other threads:[~2014-01-24 0:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 22:35 [Patch net-next v2 0/5] net_sched: act: more cleanup and improvement Cong Wang
2014-01-23 22:35 ` [Patch net-next v2 1/5] net_sched: act: hide struct tcf_common from API Cong Wang
2014-01-24 0:02 ` Stephen Hemminger
2014-01-24 0:04 ` Stephen Hemminger
2014-01-24 0:45 ` Cong Wang
2014-01-27 12:11 ` Jamal Hadi Salim
2014-01-28 5:17 ` Cong Wang
2014-01-23 22:35 ` [Patch net-next v2 2/5] net_sched: act: refactor cleanup ops Cong Wang
2014-01-23 22:35 ` [Patch net-next v2 3/5] net_sched: act: move tcf_hashinfo_init() into tcf_register_action() Cong Wang
2014-01-24 0:08 ` Stephen Hemminger [this message]
2014-01-24 0:52 ` Cong Wang
2014-01-23 22:35 ` [Patch net-next v2 4/5] net_sched: act: refuse to remove bound action outside Cong Wang
2014-01-23 22:35 ` [Patch net-next v2 5/5] net_sched: act: clean up tca_action_flush() Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123160859.147c6878@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).