From: Jiri Pirko <jiri@resnulli.us>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, fubar@us.ibm.com, vfalico@redhat.com,
andy@greyhouse.net, sfeldma@cumulusnetworks.com,
stephen@networkplumber.org, vyasevic@redhat.com,
nicolas.dichtel@6wind.com, john.r.fastabend@intel.com
Subject: Re: [patch net-next 6/6] rtnetlink: remove IFLA_SLAVES definition
Date: Thu, 23 Jan 2014 22:33:45 +0100 [thread overview]
Message-ID: <20140123213345.GA2764@minipsycho.orion> (raw)
In-Reply-To: <20140123.124716.330893227222440804.davem@davemloft.net>
Thu, Jan 23, 2014 at 09:47:16PM CET, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Wed, 22 Jan 2014 11:43:55 +0100
>
>> Not used anymore, and never should be.
>>
>> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>
>First of all your Subject doesn't match the patch, the subject mentions
>IFLA_SLAVES whereas the patch deletes IFLA_BOND_SLAVE.
Yep, sorry, IFLA_SLAVE was the original name, which I removed. Should I
repost?
>
>Secondly, you can't remove this, otherwise the next IFLA_* value added
>here will reuse that old number potentially breaking userland apps.
This has been in net-next tree for 3 days. It was a mistake, I think
there is very legit to remove this now, isn't it?
>
>I'm not applying this, sorry.
next prev parent reply other threads:[~2014-01-23 21:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 8:05 [patch net-next 0/5] fix bonding slave info API (sysfs and netlink) Jiri Pirko
2014-01-22 8:05 ` [patch net-next 1/5] bonding: change name of sysfs dir for bonding slaves Jiri Pirko
2014-01-22 8:05 ` [patch net-next 2/5] rtnetlink: put "BOND" into nl attribute names which are related to bonding Jiri Pirko
2014-01-22 15:57 ` Nicolas Dichtel
2014-01-22 8:05 ` [patch net-next 3/5] rtnetlink: provide api for getting and setting slave info Jiri Pirko
2014-01-22 8:05 ` [patch net-next 4/5] bonding: convert netlink to use slave data info api Jiri Pirko
2014-01-22 8:05 ` [patch net-next 5/5] rtnetlink: remove ndo_get_slave Jiri Pirko
2014-01-22 10:43 ` [patch net-next 6/6] rtnetlink: remove IFLA_SLAVES definition Jiri Pirko
2014-01-23 20:47 ` David Miller
2014-01-23 21:33 ` Jiri Pirko [this message]
2014-01-23 22:43 ` David Miller
2014-01-22 23:06 ` [patch net-next 0/5] fix bonding slave info API (sysfs and netlink) Scott Feldman
2014-01-23 5:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123213345.GA2764@minipsycho.orion \
--to=jiri@resnulli.us \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=sfeldma@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=vfalico@redhat.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).