From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: horia.geanta@freescale.com, steffen.klassert@secunet.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] xfrm: fix potential incorrect pointer dereference in xfrm_bundle_create
Date: Sat, 25 Jan 2014 18:05:34 -0800 (PST) [thread overview]
Message-ID: <20140125.180534.939675200515296620.davem@davemloft.net> (raw)
In-Reply-To: <1390678378.20150.5.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Sat, 25 Jan 2014 11:32:58 -0800
> Yes, but perhaps the failure test be done before the
> assignment anyway. There are more paths below the test
> where the value is not yet used.
And because we have no uses, there is no harm in the assignment.
> Perhaps something like this would be more readable.
That's a lot of useless churn if you ask me.
If we happen to be making other changes to this file, fine.
But there are much bigger fish to fry.
prev parent reply other threads:[~2014-01-26 2:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 18:47 [PATCH] xfrm: fix potential incorrect pointer dereference in xfrm_bundle_create Horia Geanta
2014-01-25 19:07 ` David Miller
2014-01-25 19:32 ` Joe Perches
2014-01-26 2:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140125.180534.939675200515296620.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=horia.geanta@freescale.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox