From: David Miller <davem@davemloft.net>
To: vfalico@redhat.com
Cc: netdev@vger.kernel.org, fubar@us.ibm.com, andy@greyhouse.net
Subject: Re: [PATCH v3 net-next 0/2] bonding: fix locking in bond_ab_arp_prob
Date: Mon, 27 Jan 2014 13:13:32 -0800 (PST) [thread overview]
Message-ID: <20140127.131332.1595843198683370255.davem@davemloft.net> (raw)
In-Reply-To: <1390829852-1943-1-git-send-email-vfalico@redhat.com>
From: Veaceslav Falico <vfalico@redhat.com>
Date: Mon, 27 Jan 2014 14:37:30 +0100
> After the latest patches, on every call of bond_ab_arp_probe() without an
> active slave I see the following warning:
...
> It happens because in bond_ab_arp_probe() we change the flags of a slave
> without holding the RTNL lock.
>
> To fix this - remove the useless curr_active_lock, RCUify it and lock RTNL
> while changing the slave's flags. Also, remove bond_ab_arp_probe() from
> under any locks in bond_ab_arp_mon().
>
> CC: Jay Vosburgh <fubar@us.ibm.com>
> CC: Andy Gospodarek <andy@greyhouse.net>
> CC: netdev@vger.kernel.org
> Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Series applied, thanks Vaeceslav.
prev parent reply other threads:[~2014-01-27 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 13:37 [PATCH v3 net-next 0/2] bonding: fix locking in bond_ab_arp_prob Veaceslav Falico
2014-01-27 13:37 ` [PATCH v3 net-next 1/2] bonding: RCUify bond_ab_arp_probe Veaceslav Falico
2014-01-27 13:37 ` [PATCH v3 net-next 2/2] bonding: restructure locking of bond_ab_arp_probe() Veaceslav Falico
2014-01-27 21:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127.131332.1595843198683370255.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox