[PATCH] ethtool: fix man page for new speeds

[PATCH] ethtool: fix man page for new speeds

[Jesse Brandeburg]

both the 20000 and 40000 speeds either were wrong or just
not documented.  Fix both.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
 ethtool.8.in |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/ethtool.8.in b/ethtool.8.in
index f587ec8..f320f7f 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -549,8 +549,12 @@ lB	l	lB.
 0x020	1000 Full
 0x8000	2500 Full	(not supported by IEEE standards)
 0x1000	10000 Full
-0x20000	20000MLD2 Full	(not supported by IEEE standards)
-0x40000	20000KR2 Full	(not supported by IEEE standards)
+0x200000	20000MLD2 Full	(not supported by IEEE standards)
+0x400000	20000KR2 Full	(not supported by IEEE standards)
+0x800000	40000KR4 Full
+0x1000000	40000CR4 Full
+0x2000000	40000SR4 Full
+0x4000000	40000LR4 Full
 .TE
 .TP
 .BI phyad \ N

Re: [PATCH] ethtool: fix man page for new speeds

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

On Tue, 2013-11-19 at 18:25 -0800, Jesse Brandeburg wrote:
> both the 20000 and 40000 speeds either were wrong or just
> not documented.  Fix both.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
[...]

Applied, thanks.

Ben.

-- 
Ben Hutchings
If at first you don't succeed, you're doing about average.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

[PATCH] ethtool.8: Add missing 1G and 10G link modes, and full names for all modes

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1768 bytes --]

The 1G and 10G backplane link modes were missing from the table for
the 'advertise' keyword.  Most link modes had only speed and duplex
listed; change them to be consistent with ethtool's own output.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
I applied this on top of your patch.

Ben.

 ethtool.8.in | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/ethtool.8.in b/ethtool.8.in
index f320f7f..bb394cc 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -541,20 +541,23 @@ a hexadecimal value using one or a combination of the following values:
 .TS
 nokeep;
 lB	l	lB.
-0x001	10 Half
-0x002	10 Full
-0x004	100 Half
-0x008	100 Full
-0x010	1000 Half	(not supported by IEEE standards)
-0x020	1000 Full
-0x8000	2500 Full	(not supported by IEEE standards)
-0x1000	10000 Full
-0x200000	20000MLD2 Full	(not supported by IEEE standards)
-0x400000	20000KR2 Full	(not supported by IEEE standards)
-0x800000	40000KR4 Full
-0x1000000	40000CR4 Full
-0x2000000	40000SR4 Full
-0x4000000	40000LR4 Full
+0x001	10baseT Half
+0x002	10baseT Full
+0x004	100baseT Half
+0x008	100baseT Full
+0x010	1000baseT Half	(not supported by IEEE standards)
+0x020	1000baseT Full
+0x20000	1000baseKX Full
+0x8000	2500baseX Full	(not supported by IEEE standards)
+0x1000	10000baseT Full
+0x40000	10000baseKX4 Full
+0x80000	10000baseKR Full
+0x200000	20000baseMLD2 Full	(not supported by IEEE standards)
+0x400000	20000baseKR2 Full	(not supported by IEEE standards)
+0x800000	40000baseKR4 Full
+0x1000000	40000baseCR4 Full
+0x2000000	40000baseSR4 Full
+0x4000000	40000baseLR4 Full
 .TE
 .TP
 .BI phyad \ N

-- 
Ben Hutchings
If at first you don't succeed, you're doing about average.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [PATCH] ethtool.8: Add missing 1G and 10G link modes, and full names for all modes

[Jesse Brandeburg]

On Mon, 27 Jan 2014 01:22:15 +0000
Ben Hutchings <ben@decadent.org.uk> wrote:

> The 1G and 10G backplane link modes were missing from the table for
> the 'advertise' keyword.  Most link modes had only speed and duplex
> listed; change them to be consistent with ethtool's own output.
> 
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> I applied this on top of your patch.

FWIW (I know you already committed it)

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

---

Thanks Ben!