netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] net/vxlan: Go over all candidate streams for GRO matching
@ 2014-01-29 16:10 Or Gerlitz
  2014-01-31  0:26 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Or Gerlitz @ 2014-01-29 16:10 UTC (permalink / raw)
  To: davem; +Cc: netdev, therbert, edumazet, Or Gerlitz

The loop in vxlan_gro_receive() over the current set of candidates for 
coalescing was wrongly aborted once a match was found. In rare cases,
this can cause a false-positives matching in the next layer GRO checks.

Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
---
 drivers/net/vxlan.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 026a313..3d6cd1c 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -596,10 +596,8 @@ static struct sk_buff **vxlan_gro_receive(struct sk_buff **head, struct sk_buff
 			NAPI_GRO_CB(p)->same_flow = 0;
 			continue;
 		}
-		goto found;
 	}
 
-found:
 	type = eh->h_proto;
 
 	rcu_read_lock();
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net/vxlan: Go over all candidate streams for GRO matching
  2014-01-29 16:10 [PATCH net] net/vxlan: Go over all candidate streams for GRO matching Or Gerlitz
@ 2014-01-31  0:26 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-01-31  0:26 UTC (permalink / raw)
  To: ogerlitz; +Cc: netdev, therbert, edumazet

From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Wed, 29 Jan 2014 18:10:10 +0200

> The loop in vxlan_gro_receive() over the current set of candidates for 
> coalescing was wrongly aborted once a match was found. In rare cases,
> this can cause a false-positives matching in the next layer GRO checks.
> 
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-01-31  0:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-29 16:10 [PATCH net] net/vxlan: Go over all candidate streams for GRO matching Or Gerlitz
2014-01-31  0:26 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).