* [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list
@ 2014-02-02 20:07 Larry Finger
2014-02-02 21:04 ` Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Larry Finger @ 2014-02-02 20:07 UTC (permalink / raw)
To: gregkh; +Cc: devel, netdev, Larry Finger
There is a typo in the device list that interchanges the vendor and
product codes for one of the entries.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 0a341d6..e9e3c76 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = {
{USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */
/*=== Customer ID ===*/
/****** 8188EUS ********/
- {USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */
+ {USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */
{USB_DEVICE(0x2001, 0x330F)}, /* DLink DWA-125 REV D1 */
{} /* Terminating entry */
};
--
1.8.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list
2014-02-02 20:07 [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list Larry Finger
@ 2014-02-02 21:04 ` Randy Dunlap
2014-02-02 21:22 ` Larry Finger
2014-02-02 21:26 ` Greg KH
2014-02-03 9:17 ` Dan Carpenter
2 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2014-02-02 21:04 UTC (permalink / raw)
To: Larry Finger, gregkh; +Cc: netdev, devel
On 02/02/2014 12:07 PM, Larry Finger wrote:
> There is a typo in the device list that interchanges the vendor and
> product codes for one of the entries.
You also changed 0x7b8 to 0x7bb.
Did you mean to do that?
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> index 0a341d6..e9e3c76 100644
> --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> @@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = {
> {USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */
> /*=== Customer ID ===*/
> /****** 8188EUS ********/
> - {USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */
> + {USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */
> {USB_DEVICE(0x2001, 0x330F)}, /* DLink DWA-125 REV D1 */
> {} /* Terminating entry */
> };
>
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list
2014-02-02 21:04 ` Randy Dunlap
@ 2014-02-02 21:22 ` Larry Finger
0 siblings, 0 replies; 6+ messages in thread
From: Larry Finger @ 2014-02-02 21:22 UTC (permalink / raw)
To: Randy Dunlap, gregkh; +Cc: devel, netdev
On 02/02/2014 03:04 PM, Randy Dunlap wrote:
> On 02/02/2014 12:07 PM, Larry Finger wrote:
>> There is a typo in the device list that interchanges the vendor and
>> product codes for one of the entries.
>
> You also changed 0x7b8 to 0x7bb.
> Did you mean to do that?
No, I did not. Thanks for catching that typo.
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list
2014-02-02 20:07 [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list Larry Finger
2014-02-02 21:04 ` Randy Dunlap
@ 2014-02-02 21:26 ` Greg KH
2014-02-03 4:16 ` Larry Finger
2014-02-03 9:17 ` Dan Carpenter
2 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2014-02-02 21:26 UTC (permalink / raw)
To: Larry Finger; +Cc: devel, netdev
On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote:
> There is a typo in the device list that interchanges the vendor and
> product codes for one of the entries.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> index 0a341d6..e9e3c76 100644
> --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> @@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = {
> {USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */
> /*=== Customer ID ===*/
> /****** 8188EUS ********/
> - {USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */
> + {USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */
Becides the b8 -> bb issue, are you sure this is correct? I've seen
lots of USB devices that got this backwards (vendor id in the product id
place), so it wouldn't be the first time it's happened.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list
2014-02-02 21:26 ` Greg KH
@ 2014-02-03 4:16 ` Larry Finger
0 siblings, 0 replies; 6+ messages in thread
From: Larry Finger @ 2014-02-03 4:16 UTC (permalink / raw)
To: Greg KH; +Cc: devel, netdev
On 02/02/2014 03:26 PM, Greg KH wrote:
> On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote:
>> There is a typo in the device list that interchanges the vendor and
>> product codes for one of the entries.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
>> index 0a341d6..e9e3c76 100644
>> --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
>> +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
>> @@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = {
>> {USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */
>> /*=== Customer ID ===*/
>> /****** 8188EUS ********/
>> - {USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */
>> + {USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */
>
> Becides the b8 -> bb issue, are you sure this is correct? I've seen
> lots of USB devices that got this backwards (vendor id in the product id
> place), so it wouldn't be the first time it's happened.
The listing at http://www.linux-usb.org/usb.ids shows that the vendor code for
AboCom Systems Inc is 0x07b8. Although it does not show a device id of 0x8179,
I'm pretty sure that this listing has reversed the two entries.
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list
2014-02-02 20:07 [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list Larry Finger
2014-02-02 21:04 ` Randy Dunlap
2014-02-02 21:26 ` Greg KH
@ 2014-02-03 9:17 ` Dan Carpenter
2 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2014-02-03 9:17 UTC (permalink / raw)
To: Larry Finger; +Cc: devel, gregkh, netdev
On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote:
> There is a typo in the device list that interchanges the vendor and
> product codes for one of the entries.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> index 0a341d6..e9e3c76 100644
> --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> @@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = {
> {USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */
> /*=== Customer ID ===*/
> /****** 8188EUS ********/
> - {USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */
> + {USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */
^^^^^^
Should this be 0x07b8?
regards,
dan carpenter
> {USB_DEVICE(0x2001, 0x330F)}, /* DLink DWA-125 REV D1 */
> {} /* Terminating entry */
> };
> --
> 1.8.4
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-03 9:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-02 20:07 [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list Larry Finger
2014-02-02 21:04 ` Randy Dunlap
2014-02-02 21:22 ` Larry Finger
2014-02-02 21:26 ` Greg KH
2014-02-03 4:16 ` Larry Finger
2014-02-03 9:17 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).