[PATCH RESEND net-next v3 0/2] bonding: Fix some issues for fail_over_mac

[PATCH RESEND net-next v3 0/2] bonding: Fix some issues for fail_over_mac

[Ding Tianhong]

The parameter fail_over_mac only affect active-backup mode, if it was
set to active or follow and works with other modes, just like RR or XOR
mode, the bonding could not set all slaves to the master's address, it
will cause the slave could not work well with master.

v1->v2: According Jay's suggestion, that we should permit setting an option
	at any time, but only have it take effect in active-backup mode, so
	I add mode checking together with fail_over_mac during enslavement and
	rebuild the patches.

v2->v3: The correct way to fix the problem is that we should not add restrictions when
    	setting options, just need to modify the bond enslave and removal processing
    	to check the mode in addition to fail_over_mac when setting a slave's MAC during
    	enslavement. The change active slave processing already only calls the fail_over_mac
    	function when in active-backup mode.

	Remove the cleanup patch because the net-next is frozen now.

Regards
Ding

Ding Tianhong (2):
  bonding: bonding: fail_over_mac should only affect AB mode at
    enslave and removal processing
  bonding: fail_over_mac should only affect AB mode in
    bond_set_mac_address()

 drivers/net/bonding/bond_main.c | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

-- 
1.8.0

Re: [PATCH RESEND net-next v3 0/2] bonding: Fix some issues for fail_over_mac

[David Miller]

From: Ding Tianhong <dingtianhong@huawei.com>
Date: Sat, 25 Jan 2014 12:58:35 +0800

> The parameter fail_over_mac only affect active-backup mode, if it was
> set to active or follow and works with other modes, just like RR or XOR
> mode, the bonding could not set all slaves to the master's address, it
> will cause the slave could not work well with master.
> 
> v1->v2: According Jay's suggestion, that we should permit setting an option
> 	at any time, but only have it take effect in active-backup mode, so
> 	I add mode checking together with fail_over_mac during enslavement and
> 	rebuild the patches.
> 
> v2->v3: The correct way to fix the problem is that we should not add restrictions when
>     	setting options, just need to modify the bond enslave and removal processing
>     	to check the mode in addition to fail_over_mac when setting a slave's MAC during
>     	enslavement. The change active slave processing already only calls the fail_over_mac
>     	function when in active-backup mode.
> 
> 	Remove the cleanup patch because the net-next is frozen now.

This series has been rotting in patchwork for a week, and desperately
needs someone to review it.

Re: [PATCH RESEND net-next v3 0/2] bonding: Fix some issues for fail_over_mac

[Jay Vosburgh]

Ding Tianhong <dingtianhong@huawei.com> wrote:

>The parameter fail_over_mac only affect active-backup mode, if it was
>set to active or follow and works with other modes, just like RR or XOR
>mode, the bonding could not set all slaves to the master's address, it
>will cause the slave could not work well with master.
>
>v1->v2: According Jay's suggestion, that we should permit setting an option
>	at any time, but only have it take effect in active-backup mode, so
>	I add mode checking together with fail_over_mac during enslavement and
>	rebuild the patches.
>
>v2->v3: The correct way to fix the problem is that we should not add restrictions when
>    	setting options, just need to modify the bond enslave and removal processing
>    	to check the mode in addition to fail_over_mac when setting a slave's MAC during
>    	enslavement. The change active slave processing already only calls the fail_over_mac
>    	function when in active-backup mode.
>
>	Remove the cleanup patch because the net-next is frozen now.
>
>Regards
>Ding

	Both patches look good to me.

Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

	-J
	
---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com

Re: [PATCH RESEND net-next v3 0/2] bonding: Fix some issues for fail_over_mac

[David Miller]

From: Jay Vosburgh <fubar@us.ibm.com>
Date: Tue, 04 Feb 2014 12:00:31 -0800

> Ding Tianhong <dingtianhong@huawei.com> wrote:
> 
>>The parameter fail_over_mac only affect active-backup mode, if it was
>>set to active or follow and works with other modes, just like RR or XOR
>>mode, the bonding could not set all slaves to the master's address, it
>>will cause the slave could not work well with master.
>>
>>v1->v2: According Jay's suggestion, that we should permit setting an option
>>	at any time, but only have it take effect in active-backup mode, so
>>	I add mode checking together with fail_over_mac during enslavement and
>>	rebuild the patches.
>>
>>v2->v3: The correct way to fix the problem is that we should not add restrictions when
>>    	setting options, just need to modify the bond enslave and removal processing
>>    	to check the mode in addition to fail_over_mac when setting a slave's MAC during
>>    	enslavement. The change active slave processing already only calls the fail_over_mac
>>    	function when in active-backup mode.
>>
>>	Remove the cleanup patch because the net-next is frozen now.
>>
>>Regards
>>Ding
> 
> 	Both patches look good to me.
> 
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

Series applied, thanks.