From: Richard Cochran <richardcochran@gmail.com>
To: "Stefan Sørensen" <stefan.sorensen@spectralink.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] ptp: Allow selecting trigger/event index in testptp
Date: Tue, 4 Feb 2014 08:20:08 +0100 [thread overview]
Message-ID: <20140204071239.GA6616@netboy> (raw)
In-Reply-To: <1391495106-4224-1-git-send-email-stefan.sorensen@spectralink.com>
Sorry to be so picky, but...
On Tue, Feb 04, 2014 at 07:25:06AM +0100, Stefan Sørensen wrote:
> - while (EOF != (c = getopt(argc, argv, "a:A:cd:e:f:ghk:p:P:sSt:v"))) {
> + while (EOF != (c = getopt(argc, argv, "a:A:cd:e:f:ghk:p:P:sSt:vi:"))) {
how about keeping alphabetical order here
> switch (c) {
> case 'a':
> oneshot = atoi(optarg);
> @@ -209,6 +211,9 @@ int main(int argc, char *argv[])
> case 't':
> adjtime = atoi(optarg);
> break;
> + case 'i':
> + index = atoi(optarg);
> + break;
and here?
> case 'h':
> usage(progname);
> return 0;
[ Yes, the 'h' is out of order.
Pleae fix that, too, if you want to. ]
Thanks,
Richard
prev parent reply other threads:[~2014-02-04 7:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 6:25 [PATCH v2] ptp: Allow selecting trigger/event index in testptp Stefan Sørensen
2014-02-04 7:20 ` Richard Cochran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204071239.GA6616@netboy \
--to=richardcochran@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).