From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: jiri@resnulli.us, cwang@twopensource.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv4: Fix runtime WARNING in rtmsg_ifa()
Date: Thu, 06 Feb 2014 20:03:00 -0800 (PST) [thread overview]
Message-ID: <20140206.200300.862172310084916848.davem@davemloft.net> (raw)
In-Reply-To: <1391585905-24851-1-git-send-email-geert@linux-m68k.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 5 Feb 2014 08:38:25 +0100
> On m68k/ARAnyM:
...
> Adding some debugging code reveals that net_fill_ifaddr() fails in
>
> put_cacheinfo(skb, ifa->ifa_cstamp, ifa->ifa_tstamp,
> preferred, valid))
>
> nla_put complains:
>
> lib/nlattr.c:454: skb_tailroom(skb) = 12, nla_total_size(attrlen) = 20
>
> Apparently commit 5c766d642bcaffd0c2a5b354db2068515b3846cf ("ipv4:
> introduce address lifetime") forgot to take into account the addition of
> struct ifa_cacheinfo in inet_nlmsg_size(). Hence add it, like is already
> done for ipv6.
>
> Suggested-by: Cong Wang <cwang@twopensource.com>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied and queued up for -stable, thanks!
prev parent reply other threads:[~2014-02-07 4:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 7:38 [PATCH] ipv4: Fix runtime WARNING in rtmsg_ifa() Geert Uytterhoeven
2014-02-05 17:30 ` Cong Wang
2014-02-05 17:39 ` Geert Uytterhoeven
2014-02-07 4:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140206.200300.862172310084916848.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=geert@linux-m68k.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).