From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: nsujir@broadcom.com, mchan@broadcom.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] tg3: cleanup an error path in tg3_phy_reset_5703_4_5()
Date: Thu, 06 Feb 2014 20:06:31 -0800 (PST) [thread overview]
Message-ID: <20140206.200631.1329672470949197117.davem@davemloft.net> (raw)
In-Reply-To: <20140205132920.GE800@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 5 Feb 2014 16:29:21 +0300
> In the original code, if tg3_readphy() fails then it does an unnecessary
> check to verify "err" is still zero and then returns -EBUSY.
>
> My static checker complains about the unnecessary "if (!err)" check and
> anyway it is better to propagate the -EBUSY error code from
> tg3_readphy() instead of hard coding it here. And really the original
> code is confusing to look at.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
prev parent reply other threads:[~2014-02-07 4:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 13:29 [patch] tg3: cleanup an error path in tg3_phy_reset_5703_4_5() Dan Carpenter
2014-02-06 0:10 ` Nithin Nayak Sujir
2014-02-07 4:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140206.200631.1329672470949197117.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).