* [patch] isdn/hisax: hex vs decimal typo in prfeatureind()
@ 2014-02-06 8:03 Dan Carpenter
2014-02-07 4:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-02-06 8:03 UTC (permalink / raw)
To: Karsten Keil
Cc: Andrew Morton, David S. Miller, Kees Cook, netdev,
kernel-janitors
This is a static checker fix, but judging from the context then I think
hexidecimal 0x80 is intended here instead of decimal 80.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Untested.
diff --git a/drivers/isdn/hisax/q931.c b/drivers/isdn/hisax/q931.c
index af1b020a81f1..b420f8bd862e 100644
--- a/drivers/isdn/hisax/q931.c
+++ b/drivers/isdn/hisax/q931.c
@@ -810,7 +810,7 @@ prfeatureind(char *dest, u_char *p)
dp += sprintf(dp, " octet 3 ");
dp += prbits(dp, *p, 8, 8);
*dp++ = '\n';
- if (!(*p++ & 80)) {
+ if (!(*p++ & 0x80)) {
dp += sprintf(dp, " octet 4 ");
dp += prbits(dp, *p++, 8, 8);
*dp++ = '\n';
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] isdn/hisax: hex vs decimal typo in prfeatureind()
2014-02-06 8:03 [patch] isdn/hisax: hex vs decimal typo in prfeatureind() Dan Carpenter
@ 2014-02-07 4:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-02-07 4:40 UTC (permalink / raw)
To: dan.carpenter; +Cc: isdn, akpm, keescook, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 6 Feb 2014 11:03:08 +0300
> This is a static checker fix, but judging from the context then I think
> hexidecimal 0x80 is intended here instead of decimal 80.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-07 4:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-06 8:03 [patch] isdn/hisax: hex vs decimal typo in prfeatureind() Dan Carpenter
2014-02-07 4:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).