From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net] bridge: fix netconsole setup over bridge Date: Thu, 06 Feb 2014 22:28:43 -0800 (PST) Message-ID: <20140206.222843.247213341900385510.davem@davemloft.net> References: <1391727652-12520-1-git-send-email-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, makita.toshiaki@lab.ntt.co.jp, stephen@networkplumber.org, cwang@twopensource.com To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:40349 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbaBGG2n (ORCPT ); Fri, 7 Feb 2014 01:28:43 -0500 In-Reply-To: <1391727652-12520-1-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Thu, 6 Feb 2014 15:00:52 -0800 > From: Cong Wang > > Commit 93d8bf9fb8f3 ("bridge: cleanup netpoll code") introduced > a check in br_netpoll_enable(), but this check is incorrect for > br_netpoll_setup(). This patch moves the code after the check > into __br_netpoll_enable() and calls it in br_netpoll_setup(). > For br_add_if(), the check is still needed. > > Fixes: 93d8bf9fb8f3 ("bridge: cleanup netpoll code") > Cc: Toshiaki Makita > Cc: Stephen Hemminger > Cc: David S. Miller > Signed-off-by: Cong Wang > Signed-off-by: Cong Wang Applied and queued up for -stable.