From: Josh Triplett <josh@joshtriplett.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Rashika Kheria' <rashika.kheria@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Armin Schindler <mac@melware.de>,
Karsten Keil <isdn@linux-pingi.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 19/26] drivers: isdn: Move prototype declaration to header file platform.h from diva_didd.c
Date: Fri, 7 Feb 2014 09:15:16 -0800 [thread overview]
Message-ID: <20140207171516.GA7298@jtriplet-mobl1> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D0F6BA76D@AcuExch.aculab.com>
On Fri, Feb 07, 2014 at 01:33:46PM +0000, David Laight wrote:
> From: Rashika Kheria
> > Move prototype declarations of function to header file
> > hardware/eicon/platform.h because they are used by more than one file.
> >
> > This eliminates the following warnings in hardware/eicon/diddfunc.c:
> > drivers/isdn/hardware/eicon/diddfunc.c:95:12: warning: no previous prototype for diddfunc_init [-
> > Wmissing-prototypes]
> > drivers/isdn/hardware/eicon/diddfunc.c:110:13: warning: no previous prototype for diddfunc_finit [-
> > Wmissing-prototypes]
> ...
> > diff --git a/drivers/isdn/hardware/eicon/diva_didd.c b/drivers/isdn/hardware/eicon/diva_didd.c
> > index fab6ccf..56d32a7 100644
> > --- a/drivers/isdn/hardware/eicon/diva_didd.c
> > +++ b/drivers/isdn/hardware/eicon/diva_didd.c
> > @@ -39,9 +39,6 @@ MODULE_LICENSE("GPL");
> > #define DBG_MINIMUM (DL_LOG + DL_FTL + DL_ERR)
> > #define DBG_DEFAULT (DBG_MINIMUM + DL_XLOG + DL_REG)
> >
> > -extern int diddfunc_init(void);
> > -extern void diddfunc_finit(void);
> > -
> > extern void DIVA_DIDD_Read(void *, int);
>
> You should move that one as well.
> There really shouldn't be 'extern' definitions for any function in
> any C files since you want the compiler to check they are correct
> when the function itself is compiled.
Absolutely, but as far as I can tell Rashika is doing this
incrementally, organized more by header than by source file, so I'd
expect a few externs in a source file to disappear at a time rather than
all in one patch.
- Josh Triplett
next prev parent reply other threads:[~2014-02-07 17:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 12:18 [PATCH 01/26] drivers: isdn: Rectify typing error in xdi_msg.h Rashika Kheria
2014-02-07 12:19 ` [PATCH 02/26] drivers: isdn: Move prototype declaration to header file um_idi.h from um_idi.c Rashika Kheria
2014-02-07 12:20 ` [PATCH 03/26] drivers: isdn: Move prototype declarations to header file um_idi.h from idifunc.c Rashika Kheria
2014-02-07 12:21 ` [PATCH 04/26] drivers: isdn: Add prototype declaration to header file platform.h from capifunc.c Rashika Kheria
2014-02-07 12:24 ` [PATCH 05/26] drivers: isdn: Move prototype declarations to header file capifunc.h from message.c Rashika Kheria
2014-02-07 12:25 ` [PATCH 06/26] drivers: isdn: Move prototype declarations to header file capifunc.h from capifunc.c and message.c Rashika Kheria
2014-02-07 12:26 ` [PATCH 07/26] drivers: isdn: Move prototype declaration to header file platform.h from divasproc.c Rashika Kheria
2014-02-07 12:27 ` [PATCH 08/26] drivers: isdn: Move prototype declaration to header file platform.h from divasmain.c and divasproc.c Rashika Kheria
2014-02-07 12:28 ` [PATCH 09/26] drivers: isdn: Include appropriate header file in diva.c Rashika Kheria
2014-02-07 12:29 ` [PATCH 10/26] drivers: isdn: Move prototype declaration to appropriate header file diva.h Rashika Kheria
2014-02-07 12:33 ` [PATCH 11/26] drivers: isdn: Move prototype declarations to header file platform.h from mntfunc.c Rashika Kheria
2014-02-07 12:34 ` [PATCH 12/26] drivers: isdn: Mark functions as static and remove unused function in hfcmulti.c Rashika Kheria
2014-02-07 12:35 ` [PATCH 13/26] drivers: isdn: Mark functions as static in avmfritz.c Rashika Kheria
2014-02-07 12:36 ` [PATCH 14/26] drivers: isdn: Mark function as static in w6692.c Rashika Kheria
2014-02-07 12:37 ` [PATCH 15/26] drivers: isdn: Mark function as static in mISDNipac.c Rashika Kheria
2014-02-07 12:38 ` [PATCH 16/26] drivers: isdn: Move prototype declarations to appropriate header file hscx.h from elsa_ser.c Rashika Kheria
2014-02-07 12:39 ` [PATCH 17/26] drivers: isdn: Move prototype declaration to header file platform.h from divasi.c Rashika Kheria
2014-02-07 12:41 ` [PATCH 18/26] drivers: isdn: Mark functions as static in layer2.c Rashika Kheria
2014-02-07 12:42 ` [PATCH 19/26] drivers: isdn: Move prototype declaration to header file platform.h from diva_didd.c Rashika Kheria
2014-02-07 13:33 ` David Laight
2014-02-07 17:15 ` Josh Triplett [this message]
2014-02-07 17:22 ` David Laight
2014-02-07 17:41 ` Josh Triplett
2014-02-07 12:43 ` [PATCH 20/26] drivers: isdn: Move prototype declaration to header file platform.h from os_bri.c Rashika Kheria
2014-02-07 12:44 ` [PATCH 21/26] drivers: isdn: Move prototype declaration to header file platform.h from os_4bri.c Rashika Kheria
2014-02-07 12:45 ` [PATCH 22/26] drivers: isdn: Move prototype declaration to header file platform.h from os_pri.c Rashika Kheria
2014-02-07 12:46 ` [PATCH 23/26] drivers: isdn: Move prototype declaration to header file platform.h from divamnt.c Rashika Kheria
2014-02-07 12:47 ` [PATCH 24/26] drivers: isdn: Move prototype declaration to header file hisax.h from config.c Rashika Kheria
2014-02-07 12:48 ` [PATCH 25/26] drivers: isdn: Move prototype declaration to header file dadapter.h Rashika Kheria
2014-02-07 12:49 ` [PATCH 26/26] drivers: isdn: Move prototype declaration to header file platform.h from divasmain.c Rashika Kheria
2014-02-07 18:48 ` [PATCH 01/26] drivers: isdn: Rectify typing error in xdi_msg.h Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207171516.GA7298@jtriplet-mobl1 \
--to=josh@joshtriplett.org \
--cc=David.Laight@ACULAB.COM \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
--cc=netdev@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).