* [PATCH] wan: dlci: Remove unused netdev_priv pointer
@ 2014-02-07 23:21 Christian Engelmayer
2014-02-10 2:41 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Christian Engelmayer @ 2014-02-07 23:21 UTC (permalink / raw)
To: netdev; +Cc: David Miller, Zefan Li, Jiri Pirko
[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]
Remove occurrences of unused pointer to network device private data in
functions dlci_header() and dlci_receive().
Detected by Coverity: CID 139844, CID 139845.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
drivers/net/wan/dlci.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/wan/dlci.c b/drivers/net/wan/dlci.c
index 0d1c759..19f7cb2 100644
--- a/drivers/net/wan/dlci.c
+++ b/drivers/net/wan/dlci.c
@@ -71,12 +71,9 @@ static int dlci_header(struct sk_buff *skb, struct net_device *dev,
const void *saddr, unsigned len)
{
struct frhdr hdr;
- struct dlci_local *dlp;
unsigned int hlen;
char *dest;
- dlp = netdev_priv(dev);
-
hdr.control = FRAD_I_UI;
switch (type)
{
@@ -107,11 +104,9 @@ static int dlci_header(struct sk_buff *skb, struct net_device *dev,
static void dlci_receive(struct sk_buff *skb, struct net_device *dev)
{
- struct dlci_local *dlp;
struct frhdr *hdr;
int process, header;
- dlp = netdev_priv(dev);
if (!pskb_may_pull(skb, sizeof(*hdr))) {
netdev_notice(dev, "invalid data no header\n");
dev->stats.rx_errors++;
--
1.8.3.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wan: dlci: Remove unused netdev_priv pointer
2014-02-07 23:21 [PATCH] wan: dlci: Remove unused netdev_priv pointer Christian Engelmayer
@ 2014-02-10 2:41 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-02-10 2:41 UTC (permalink / raw)
To: cengelma; +Cc: netdev, lizefan, jiri
From: Christian Engelmayer <cengelma@gmx.at>
Date: Sat, 8 Feb 2014 00:21:10 +0100
> Remove occurrences of unused pointer to network device private data in
> functions dlci_header() and dlci_receive().
>
> Detected by Coverity: CID 139844, CID 139845.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-10 2:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-07 23:21 [PATCH] wan: dlci: Remove unused netdev_priv pointer Christian Engelmayer
2014-02-10 2:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).