From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 03/13] net: Include appropriate header file in caif/cfsrvl.c
Date: Sat, 8 Feb 2014 12:04:59 -0800 [thread overview]
Message-ID: <20140208200459.GC20885@leaf> (raw)
In-Reply-To: <6b6ceef0f79bffec0ec14784dc3d921d53231a3b.1391888654.git.rashika.kheria@gmail.com>
On Sun, Feb 09, 2014 at 01:21:51AM +0530, Rashika Kheria wrote:
> Include appropriate header file net/caif/caif_dev.h in caif/cfsrvl.c
> because it has prototype declaration of functions defined in
> caif/cfsrvl.c.
>
> This eliminates the following warning in caif/cfsrvl.c:
> net/caif/cfsrvl.c:198:6: warning: no previous prototype for ‘caif_free_client’ [-Wmissing-prototypes]
> net/caif/cfsrvl.c:208:6: warning: no previous prototype for ‘caif_client_register_refcnt’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> net/caif/cfsrvl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/caif/cfsrvl.c b/net/caif/cfsrvl.c
> index 353f793..a6e1154 100644
> --- a/net/caif/cfsrvl.c
> +++ b/net/caif/cfsrvl.c
> @@ -15,6 +15,7 @@
> #include <net/caif/caif_layer.h>
> #include <net/caif/cfsrvl.h>
> #include <net/caif/cfpkt.h>
> +#include <net/caif/caif_dev.h>
>
> #define SRVL_CTRL_PKT_SIZE 1
> #define SRVL_FLOW_OFF 0x81
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2014-02-08 20:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 19:47 [PATCH 01/13] net: Mark function as static in 9p/client.c Rashika Kheria
2014-02-08 19:49 ` [PATCH 02/13] net: Include appropriate header file in caif/caif_dev.c Rashika Kheria
2014-02-08 20:04 ` Josh Triplett
2014-02-08 19:51 ` [PATCH 03/13] net: Include appropriate header file in caif/cfsrvl.c Rashika Kheria
2014-02-08 20:04 ` Josh Triplett [this message]
2014-02-08 19:53 ` [PATCH 04/13] net: Mark functions as static in core/dev.c Rashika Kheria
2014-02-08 20:07 ` Josh Triplett
2014-02-08 21:18 ` Veaceslav Falico
2014-02-08 19:55 ` [PATCH 05/13] net: Mark function as static in core/filter.c Rashika Kheria
2014-02-08 20:09 ` Josh Triplett
2014-02-08 19:58 ` [PATCH 06/13] net: Move prototype declaration to appropriate header file from decnet/af_decnet.c Rashika Kheria
2014-02-08 20:10 ` Josh Triplett
2014-02-08 19:59 ` [PATCH 07/13] net: Move prototype declaration to header file include/net/dn.h from net/decnet/af_decnet.c Rashika Kheria
2014-02-08 20:11 ` Josh Triplett
2014-02-08 20:02 ` [PATCH 08/13] net: Move prototype declaration to include/net/ipx.h from net/ipx/ipx_route.c Rashika Kheria
2014-02-08 20:11 ` Josh Triplett
2014-02-08 20:03 ` [PATCH 09/13] net: Move prototype declaration to header file include/net/ipx.h from net/ipx/af_ipx.c Rashika Kheria
2014-02-08 20:12 ` Josh Triplett
2014-02-08 20:04 ` [PATCH 01/13] net: Mark function as static in 9p/client.c Josh Triplett
2014-02-08 20:05 ` [PATCH 10/13] net: Move prototype declaration to header file include/net/datalink.h from net/ipx/af_ipx.c Rashika Kheria
2014-02-08 20:12 ` Josh Triplett
2014-02-08 20:07 ` [PATCH 11/13] net: Move prototype declaration to header file include/net/net_namespace.h " Rashika Kheria
2014-02-08 20:14 ` Josh Triplett
2014-02-08 20:09 ` [PATCH 12/13] net: Include appropriate header file in netfilter/nft_lookup.c Rashika Kheria
2014-02-08 20:14 ` Josh Triplett
2014-02-08 20:10 ` [PATCH 13/13] net: Mark functions as static in net/sunrpc/svc_xprt.c Rashika Kheria
[not found] ` <259f3dc38d7115eccf3aaa2aa7de2414a47f90a2.1391888654.git.rashika.kheria-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-08 20:23 ` Josh Triplett
2014-02-11 17:12 ` J. Bruce Fields
2014-02-09 14:27 ` [PATCH v2 01/13] net: Mark function as static in 9p/client.c Rashika Kheria
2014-02-09 14:29 ` [PATCH v2 02/13] net: Include appropriate header file in caif/caif_dev.c Rashika Kheria
2014-02-09 14:32 ` [PATCH v2 03/13] net: Include appropriate header file in caif/cfsrvl.c Rashika Kheria
2014-02-09 14:56 ` [PATCH v2 04/13] net: Mark functions as static in core/dev.c Rashika Kheria
2014-02-09 16:50 ` [PATCH v2 06/13] net: Move prototype declaration to appropriate header file from decnet/af_decnet.c Rashika Kheria
2014-02-09 16:52 ` [PATCH v2 07/13] net: Move prototype declaration to header file include/net/dn.h from net/decnet/af_decnet.c Rashika Kheria
2014-02-09 16:54 ` [PATCH v2 08/13] net: Move prototype declaration to include/net/ipx.h from net/ipx/ipx_route.c Rashika Kheria
2014-02-09 16:56 ` [PATCH v2 09/13] net: Move prototype declaration to header file include/net/ipx.h from net/ipx/af_ipx.c Rashika Kheria
2014-02-09 16:57 ` [PATCH v2 10/13] net: Move prototype declaration to header file include/net/datalink.h " Rashika Kheria
2014-02-09 16:59 ` [PATCH v2 11/13] net: Move prototype declaration to header file include/net/net_namespace.h " Rashika Kheria
2014-02-09 17:01 ` [PATCH v2 12/13] net: Include appropriate header file in netfilter/nft_lookup.c Rashika Kheria
[not found] ` <6f029c895035908595957fb16ab445c82793c77d.1391955924.git.rashika.kheria-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-09 17:03 ` [PATCH v2 13/13] net: Mark functions as static in net/sunrpc/svc_xprt.c Rashika Kheria
2014-02-10 2:02 ` [PATCH v2 01/13] net: Mark function as static in 9p/client.c David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140208200459.GC20885@leaf \
--to=josh@joshtriplett.org \
--cc=davem@davemloft.net \
--cc=dmitry.tarnyagin@lockless.no \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).