From: Veaceslav Falico <vfalico@redhat.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, josh@joshtriplett.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Jiri Pirko <jiri@resnulli.us>,
Pravin B Shelar <pshelar@nicira.com>,
Cong Wang <amwang@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 04/13] net: Mark functions as static in core/dev.c
Date: Sat, 8 Feb 2014 22:18:50 +0100 [thread overview]
Message-ID: <20140208211850.GB1205@redhat.com> (raw)
In-Reply-To: <ccd9586270a8ebb87aeadc10feff52857b7f907c.1391888654.git.rashika.kheria@gmail.com>
On Sun, Feb 09, 2014 at 01:23:45AM +0530, Rashika Kheria wrote:
>Mark functions as static in core/dev.c because they are not used outside
>this file.
>
>This eliminates the following warning in core/dev.c:
>net/core/dev.c:2806:5: warning: no previous prototype for ‘__dev_queue_xmit’ [-Wmissing-prototypes]
>net/core/dev.c:4640:5: warning: no previous prototype for ‘netdev_adjacent_sysfs_add’ [-Wmissing-prototypes]
>net/core/dev.c:4650:6: warning: no previous prototype for ‘netdev_adjacent_sysfs_del’ [-Wmissing-prototypes]
>
>Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Veaceslav Falico <vfalico@redhat.com>
>---
> net/core/dev.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/net/core/dev.c b/net/core/dev.c
>index 3721db7..4ad1b78 100644
>--- a/net/core/dev.c
>+++ b/net/core/dev.c
>@@ -2803,7 +2803,7 @@ EXPORT_SYMBOL(dev_loopback_xmit);
> * the BH enable code must have IRQs enabled so that it will not deadlock.
> * --BLG
> */
>-int __dev_queue_xmit(struct sk_buff *skb, void *accel_priv)
>+static int __dev_queue_xmit(struct sk_buff *skb, void *accel_priv)
> {
> struct net_device *dev = skb->dev;
> struct netdev_queue *txq;
>@@ -4637,7 +4637,7 @@ struct net_device *netdev_master_upper_dev_get_rcu(struct net_device *dev)
> }
> EXPORT_SYMBOL(netdev_master_upper_dev_get_rcu);
>
>-int netdev_adjacent_sysfs_add(struct net_device *dev,
>+static int netdev_adjacent_sysfs_add(struct net_device *dev,
> struct net_device *adj_dev,
> struct list_head *dev_list)
> {
>@@ -4647,7 +4647,7 @@ int netdev_adjacent_sysfs_add(struct net_device *dev,
> return sysfs_create_link(&(dev->dev.kobj), &(adj_dev->dev.kobj),
> linkname);
> }
>-void netdev_adjacent_sysfs_del(struct net_device *dev,
>+static void netdev_adjacent_sysfs_del(struct net_device *dev,
> char *name,
> struct list_head *dev_list)
> {
>--
>1.7.9.5
>
next prev parent reply other threads:[~2014-02-08 21:18 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 19:47 [PATCH 01/13] net: Mark function as static in 9p/client.c Rashika Kheria
2014-02-08 19:49 ` [PATCH 02/13] net: Include appropriate header file in caif/caif_dev.c Rashika Kheria
2014-02-08 20:04 ` Josh Triplett
2014-02-08 19:51 ` [PATCH 03/13] net: Include appropriate header file in caif/cfsrvl.c Rashika Kheria
2014-02-08 20:04 ` Josh Triplett
2014-02-08 19:53 ` [PATCH 04/13] net: Mark functions as static in core/dev.c Rashika Kheria
2014-02-08 20:07 ` Josh Triplett
2014-02-08 21:18 ` Veaceslav Falico [this message]
2014-02-08 19:55 ` [PATCH 05/13] net: Mark function as static in core/filter.c Rashika Kheria
2014-02-08 20:09 ` Josh Triplett
2014-02-08 19:58 ` [PATCH 06/13] net: Move prototype declaration to appropriate header file from decnet/af_decnet.c Rashika Kheria
2014-02-08 20:10 ` Josh Triplett
2014-02-08 19:59 ` [PATCH 07/13] net: Move prototype declaration to header file include/net/dn.h from net/decnet/af_decnet.c Rashika Kheria
2014-02-08 20:11 ` Josh Triplett
2014-02-08 20:02 ` [PATCH 08/13] net: Move prototype declaration to include/net/ipx.h from net/ipx/ipx_route.c Rashika Kheria
2014-02-08 20:11 ` Josh Triplett
2014-02-08 20:03 ` [PATCH 09/13] net: Move prototype declaration to header file include/net/ipx.h from net/ipx/af_ipx.c Rashika Kheria
2014-02-08 20:12 ` Josh Triplett
2014-02-08 20:04 ` [PATCH 01/13] net: Mark function as static in 9p/client.c Josh Triplett
2014-02-08 20:05 ` [PATCH 10/13] net: Move prototype declaration to header file include/net/datalink.h from net/ipx/af_ipx.c Rashika Kheria
2014-02-08 20:12 ` Josh Triplett
2014-02-08 20:07 ` [PATCH 11/13] net: Move prototype declaration to header file include/net/net_namespace.h " Rashika Kheria
2014-02-08 20:14 ` Josh Triplett
2014-02-08 20:09 ` [PATCH 12/13] net: Include appropriate header file in netfilter/nft_lookup.c Rashika Kheria
2014-02-08 20:14 ` Josh Triplett
2014-02-08 20:10 ` [PATCH 13/13] net: Mark functions as static in net/sunrpc/svc_xprt.c Rashika Kheria
[not found] ` <259f3dc38d7115eccf3aaa2aa7de2414a47f90a2.1391888654.git.rashika.kheria-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-08 20:23 ` Josh Triplett
2014-02-11 17:12 ` J. Bruce Fields
2014-02-09 14:27 ` [PATCH v2 01/13] net: Mark function as static in 9p/client.c Rashika Kheria
2014-02-09 14:29 ` [PATCH v2 02/13] net: Include appropriate header file in caif/caif_dev.c Rashika Kheria
2014-02-09 14:32 ` [PATCH v2 03/13] net: Include appropriate header file in caif/cfsrvl.c Rashika Kheria
2014-02-09 14:56 ` [PATCH v2 04/13] net: Mark functions as static in core/dev.c Rashika Kheria
2014-02-09 16:50 ` [PATCH v2 06/13] net: Move prototype declaration to appropriate header file from decnet/af_decnet.c Rashika Kheria
2014-02-09 16:52 ` [PATCH v2 07/13] net: Move prototype declaration to header file include/net/dn.h from net/decnet/af_decnet.c Rashika Kheria
2014-02-09 16:54 ` [PATCH v2 08/13] net: Move prototype declaration to include/net/ipx.h from net/ipx/ipx_route.c Rashika Kheria
2014-02-09 16:56 ` [PATCH v2 09/13] net: Move prototype declaration to header file include/net/ipx.h from net/ipx/af_ipx.c Rashika Kheria
2014-02-09 16:57 ` [PATCH v2 10/13] net: Move prototype declaration to header file include/net/datalink.h " Rashika Kheria
2014-02-09 16:59 ` [PATCH v2 11/13] net: Move prototype declaration to header file include/net/net_namespace.h " Rashika Kheria
2014-02-09 17:01 ` [PATCH v2 12/13] net: Include appropriate header file in netfilter/nft_lookup.c Rashika Kheria
[not found] ` <6f029c895035908595957fb16ab445c82793c77d.1391955924.git.rashika.kheria-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-09 17:03 ` [PATCH v2 13/13] net: Mark functions as static in net/sunrpc/svc_xprt.c Rashika Kheria
2014-02-10 2:02 ` [PATCH v2 01/13] net: Mark function as static in 9p/client.c David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140208211850.GB1205@redhat.com \
--to=vfalico@redhat.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pshelar@nicira.com \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).