* [PATCH] 3c59x: Remove unused pointer in vortex_eisa_cleanup()
@ 2014-02-08 17:11 Christian Engelmayer
2014-02-08 19:10 ` [PATCH/RESEND] " Christian Engelmayer
2014-02-10 3:06 ` [PATCH] " David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Christian Engelmayer @ 2014-02-08 17:11 UTC (permalink / raw)
To: Steffen Klassert; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
Remove unused network device private data pointer 'vp' in function
vortex_eisa_cleanup(). Detected by Coverity: CID 139826.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
drivers/net/ethernet/3com/3c59x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c
index 0f4241c..238ccea 100644
--- a/drivers/net/ethernet/3com/3c59x.c
+++ b/drivers/net/ethernet/3com/3c59x.c
@@ -3294,7 +3294,6 @@ static int __init vortex_init(void)
static void __exit vortex_eisa_cleanup(void)
{
- struct vortex_private *vp;
void __iomem *ioaddr;
#ifdef CONFIG_EISA
@@ -3303,7 +3302,6 @@ static void __exit vortex_eisa_cleanup(void)
#endif
if (compaq_net_device) {
- vp = netdev_priv(compaq_net_device);
ioaddr = ioport_map(compaq_net_device->base_addr,
VORTEX_TOTAL_SIZE);
--
1.8.3.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH/RESEND] 3c59x: Remove unused pointer in vortex_eisa_cleanup()
2014-02-08 17:11 [PATCH] 3c59x: Remove unused pointer in vortex_eisa_cleanup() Christian Engelmayer
@ 2014-02-08 19:10 ` Christian Engelmayer
2014-02-10 12:50 ` Steffen Klassert
2014-02-10 3:06 ` [PATCH] " David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Christian Engelmayer @ 2014-02-08 19:10 UTC (permalink / raw)
To: steffen; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
Remove unused network device private data pointer 'vp' in function
vortex_eisa_cleanup(). Detected by Coverity: CID 139826.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
Resend using address steffen@klassert.de as retrieved from the mail delivery
fail notification by tu-chemnitz.de. Information in MAINTAINERS seems to be
outdated on that point.
---
drivers/net/ethernet/3com/3c59x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c
index 0f4241c..238ccea 100644
--- a/drivers/net/ethernet/3com/3c59x.c
+++ b/drivers/net/ethernet/3com/3c59x.c
@@ -3294,7 +3294,6 @@ static int __init vortex_init(void)
static void __exit vortex_eisa_cleanup(void)
{
- struct vortex_private *vp;
void __iomem *ioaddr;
#ifdef CONFIG_EISA
@@ -3303,7 +3302,6 @@ static void __exit vortex_eisa_cleanup(void)
#endif
if (compaq_net_device) {
- vp = netdev_priv(compaq_net_device);
ioaddr = ioport_map(compaq_net_device->base_addr,
VORTEX_TOTAL_SIZE);
--
1.8.3.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH/RESEND] 3c59x: Remove unused pointer in vortex_eisa_cleanup()
2014-02-08 19:10 ` [PATCH/RESEND] " Christian Engelmayer
@ 2014-02-10 12:50 ` Steffen Klassert
0 siblings, 0 replies; 4+ messages in thread
From: Steffen Klassert @ 2014-02-10 12:50 UTC (permalink / raw)
To: Christian Engelmayer; +Cc: netdev
On Sat, Feb 08, 2014 at 08:10:23PM +0100, Christian Engelmayer wrote:
> Remove unused network device private data pointer 'vp' in function
> vortex_eisa_cleanup(). Detected by Coverity: CID 139826.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> Resend using address steffen@klassert.de as retrieved from the mail delivery
> fail notification by tu-chemnitz.de. Information in MAINTAINERS seems to be
> outdated on that point.
Oh yes, it expired at the beginning of the year. I'll do a
patch to update the maintainers entry. Thanks for the info!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] 3c59x: Remove unused pointer in vortex_eisa_cleanup()
2014-02-08 17:11 [PATCH] 3c59x: Remove unused pointer in vortex_eisa_cleanup() Christian Engelmayer
2014-02-08 19:10 ` [PATCH/RESEND] " Christian Engelmayer
@ 2014-02-10 3:06 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2014-02-10 3:06 UTC (permalink / raw)
To: cengelma; +Cc: klassert, netdev
From: Christian Engelmayer <cengelma@gmx.at>
Date: Sat, 8 Feb 2014 18:11:17 +0100
> Remove unused network device private data pointer 'vp' in function
> vortex_eisa_cleanup(). Detected by Coverity: CID 139826.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-10 12:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-08 17:11 [PATCH] 3c59x: Remove unused pointer in vortex_eisa_cleanup() Christian Engelmayer
2014-02-08 19:10 ` [PATCH/RESEND] " Christian Engelmayer
2014-02-10 12:50 ` Steffen Klassert
2014-02-10 3:06 ` [PATCH] " David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).