From: Christian Engelmayer <cengelma@gmx.at>
To: Jon Mason <jdmason@kudzu.us>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
Jingoo Han <jg1.han@samsung.com>,
Masanari Iida <standby24x7@gmail.com>,
John Stultz <john.stultz@linaro.org>,
dingtianhong <dingtianhong@huawei.com>,
Ben Hutchings <bhutchings@solarflare.com>,
stephen hemminger <stephen@networkplumber.org>,
Tom Herbert <therbert@google.com>
Subject: [PATCH] net: vxge: Remove unused device pointer
Date: Sun, 9 Feb 2014 00:16:17 +0100 [thread overview]
Message-ID: <20140209001617.1d1543d4@spike> (raw)
[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]
Remove occurrences of unused struct __vxge_hw_device pointer in functions
vxge_learn_mac() and vxge_rem_isr().
Detected by Coverity: CID 139839, CID 139842.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
drivers/net/ethernet/neterion/vxge/vxge-main.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
index 1ded50ca..e46e869 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
@@ -726,9 +726,6 @@ static int vxge_learn_mac(struct vxgedev *vdev, u8 *mac_header)
int vpath_idx = 0;
enum vxge_hw_status status = VXGE_HW_OK;
struct vxge_vpath *vpath = NULL;
- struct __vxge_hw_device *hldev;
-
- hldev = pci_get_drvdata(vdev->pdev);
mac_address = (u8 *)&mac_addr;
memcpy(mac_address, mac_header, ETH_ALEN);
@@ -2443,9 +2440,6 @@ static void vxge_rem_msix_isr(struct vxgedev *vdev)
static void vxge_rem_isr(struct vxgedev *vdev)
{
- struct __vxge_hw_device *hldev;
- hldev = pci_get_drvdata(vdev->pdev);
-
#ifdef CONFIG_PCI_MSI
if (vdev->config.intr_type == MSI_X) {
vxge_rem_msix_isr(vdev);
--
1.8.3.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2014-02-08 23:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 23:16 Christian Engelmayer [this message]
2014-02-10 0:01 ` [PATCH] net: vxge: Remove unused device pointer Jingoo Han
2014-02-10 3:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140209001617.1d1543d4@spike \
--to=cengelma@gmx.at \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=jdmason@kudzu.us \
--cc=jg1.han@samsung.com \
--cc=john.stultz@linaro.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=standby24x7@gmail.com \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).