* [PATCH] net: vxge: Remove unused device pointer
@ 2014-02-08 23:16 Christian Engelmayer
2014-02-10 0:01 ` Jingoo Han
2014-02-10 3:11 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Christian Engelmayer @ 2014-02-08 23:16 UTC (permalink / raw)
To: Jon Mason
Cc: netdev, David Miller, Patrick McHardy, Jingoo Han, Masanari Iida,
John Stultz, dingtianhong, Ben Hutchings, stephen hemminger,
Tom Herbert
[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]
Remove occurrences of unused struct __vxge_hw_device pointer in functions
vxge_learn_mac() and vxge_rem_isr().
Detected by Coverity: CID 139839, CID 139842.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
drivers/net/ethernet/neterion/vxge/vxge-main.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
index 1ded50ca..e46e869 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
@@ -726,9 +726,6 @@ static int vxge_learn_mac(struct vxgedev *vdev, u8 *mac_header)
int vpath_idx = 0;
enum vxge_hw_status status = VXGE_HW_OK;
struct vxge_vpath *vpath = NULL;
- struct __vxge_hw_device *hldev;
-
- hldev = pci_get_drvdata(vdev->pdev);
mac_address = (u8 *)&mac_addr;
memcpy(mac_address, mac_header, ETH_ALEN);
@@ -2443,9 +2440,6 @@ static void vxge_rem_msix_isr(struct vxgedev *vdev)
static void vxge_rem_isr(struct vxgedev *vdev)
{
- struct __vxge_hw_device *hldev;
- hldev = pci_get_drvdata(vdev->pdev);
-
#ifdef CONFIG_PCI_MSI
if (vdev->config.intr_type == MSI_X) {
vxge_rem_msix_isr(vdev);
--
1.8.3.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: vxge: Remove unused device pointer
2014-02-08 23:16 [PATCH] net: vxge: Remove unused device pointer Christian Engelmayer
@ 2014-02-10 0:01 ` Jingoo Han
2014-02-10 3:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2014-02-10 0:01 UTC (permalink / raw)
To: 'Christian Engelmayer', 'Jon Mason'
Cc: netdev, 'David Miller', 'Patrick McHardy',
'Masanari Iida', 'John Stultz',
'dingtianhong', 'Ben Hutchings',
'stephen hemminger', 'Tom Herbert',
'Jingoo Han'
On Sunday, February 09, 2014 8:16 AM, Christian Engelmayer wrote:
>
> Remove occurrences of unused struct __vxge_hw_device pointer in functions
> vxge_learn_mac() and vxge_rem_isr().
>
> Detected by Coverity: CID 139839, CID 139842.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/net/ethernet/neterion/vxge/vxge-main.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-
> main.c
> index 1ded50ca..e46e869 100644
> --- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
> +++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
> @@ -726,9 +726,6 @@ static int vxge_learn_mac(struct vxgedev *vdev, u8 *mac_header)
> int vpath_idx = 0;
> enum vxge_hw_status status = VXGE_HW_OK;
> struct vxge_vpath *vpath = NULL;
> - struct __vxge_hw_device *hldev;
> -
> - hldev = pci_get_drvdata(vdev->pdev);
>
> mac_address = (u8 *)&mac_addr;
> memcpy(mac_address, mac_header, ETH_ALEN);
> @@ -2443,9 +2440,6 @@ static void vxge_rem_msix_isr(struct vxgedev *vdev)
>
> static void vxge_rem_isr(struct vxgedev *vdev)
> {
> - struct __vxge_hw_device *hldev;
> - hldev = pci_get_drvdata(vdev->pdev);
> -
> #ifdef CONFIG_PCI_MSI
> if (vdev->config.intr_type == MSI_X) {
> vxge_rem_msix_isr(vdev);
> --
> 1.8.3.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: vxge: Remove unused device pointer
2014-02-08 23:16 [PATCH] net: vxge: Remove unused device pointer Christian Engelmayer
2014-02-10 0:01 ` Jingoo Han
@ 2014-02-10 3:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-02-10 3:11 UTC (permalink / raw)
To: cengelma
Cc: jdmason, netdev, kaber, jg1.han, standby24x7, john.stultz,
dingtianhong, bhutchings, stephen, therbert
From: Christian Engelmayer <cengelma@gmx.at>
Date: Sun, 9 Feb 2014 00:16:17 +0100
> Remove occurrences of unused struct __vxge_hw_device pointer in functions
> vxge_learn_mac() and vxge_rem_isr().
>
> Detected by Coverity: CID 139839, CID 139842.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-10 3:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-08 23:16 [PATCH] net: vxge: Remove unused device pointer Christian Engelmayer
2014-02-10 0:01 ` Jingoo Han
2014-02-10 3:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).