From: David Miller <davem@davemloft.net>
To: ryao@gentoo.org
Cc: netdev@vger.kernel.org
Subject: Latest version of zero-copy fix
Date: Mon, 10 Feb 2014 15:21:50 -0800 (PST) [thread overview]
Message-ID: <20140210.152150.574073124161003333.davem@davemloft.net> (raw)
So now the patch only tests is_vmalloc_addr(), did you test this
version with the situation that triggers the given backtrace?
[<ffffffff814878ce>] p9_virtio_zc_request+0x45e/0x510
[<ffffffff814814ed>] p9_client_zc_rpc.constprop.16+0xfd/0x4f0
[<ffffffff814839dd>] p9_client_read+0x15d/0x240
[<ffffffff811c8440>] v9fs_fid_readn+0x50/0xa0
[<ffffffff811c84a0>] v9fs_file_readn+0x10/0x20
[<ffffffff811c84e7>] v9fs_file_read+0x37/0x70
[<ffffffff8114e3fb>] vfs_read+0x9b/0x160
[<ffffffff81153571>] kernel_read+0x41/0x60
[<ffffffff810c83ab>] copy_module_from_fd.isra.34+0xfb/0x180
This is reading from v9fs into a module address.
It's going generate the same backtrace with your fix.
I don't think the situation was sufficiently explained to Linus. In
fact, I didn't see the above backtrace mentioned at all.
next reply other threads:[~2014-02-10 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 23:21 David Miller [this message]
2014-02-11 1:31 ` Latest version of zero-copy fix Richard Yao
2014-02-11 1:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210.152150.574073124161003333.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ryao@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox