From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: alex.aring@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] 6lowpan: fix lockdep splats
Date: Mon, 10 Feb 2014 17:51:56 -0800 (PST) [thread overview]
Message-ID: <20140210.175156.1760225535255103785.davem@davemloft.net> (raw)
In-Reply-To: <1392061355.6615.52.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 10 Feb 2014 11:42:35 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> When a device ndo_start_xmit() calls again dev_queue_xmit(),
> lockdep can complain because dev_queue_xmit() is re-entered and the
> spinlocks protecting tx queues share a common lockdep class.
>
> Same issue was fixed for bonding/l2tp/ppp in commits
>
> 0daa2303028a6 ("[PATCH] bonding: lockdep annotation")
> 49ee49202b4ac ("bonding: set qdisc_tx_busylock to avoid LOCKDEP splat")
> 23d3b8bfb8eb2 ("net: qdisc busylock needs lockdep annotations ")
> 303c07db487be ("ppp: set qdisc_tx_busylock to avoid LOCKDEP splat ")
>
> Reported-by: Alexander Aring <alex.aring@gmail.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Tested-by: Alexander Aring <alex.aring@gmail.com>
Applied, thanks Eric.
prev parent reply other threads:[~2014-02-11 1:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 10:20 6lowpan: lockless tx queue of routing netlink device Alexander Aring
2014-02-09 12:41 ` Eric Dumazet
[not found] ` <1391949707.10160.130.camel-XN9IlZ5yJG9HTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2014-02-10 17:33 ` Alexander Aring
2014-02-10 18:16 ` Eric Dumazet
2014-02-10 18:21 ` Alexander Aring
2014-02-10 19:26 ` Eric Dumazet
2014-02-10 19:31 ` Alexander Aring
2014-02-10 19:42 ` [PATCH] 6lowpan: fix lockdep splats Eric Dumazet
2014-02-11 1:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210.175156.1760225535255103785.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.aring@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).