From mboxrd@z Thu Jan 1 00:00:00 1970 From: Veaceslav Falico Subject: Re: [PATCH net] bonding: remove unwanted bond lock for enslave processing Date: Mon, 10 Feb 2014 09:49:26 +0100 Message-ID: <20140210084925.GD1205@redhat.com> References: <52F88EF7.606@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Cc: Jay Vosburgh , Andy Gospodarek , "David S. Miller" , Netdev To: Ding Tianhong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37973 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbaBJItk (ORCPT ); Mon, 10 Feb 2014 03:49:40 -0500 Content-Disposition: inline In-Reply-To: <52F88EF7.606@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Feb 10, 2014 at 04:33:59PM +0800, Ding Tianhong wrote: >The bond enslave processing don't hold bond->lock anymore, >so release an unlocked rw lock will cause warning message, >remove the unwanted read_unlock(&bond->lock). > >Cc: Jay Vosburgh >Cc: Veaceslav Falico >Cc: Andy Gospodarek >Signed-off-by: Ding Tianhong Good catch. Acked-by: Veaceslav Falico >--- > drivers/net/bonding/bond_main.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >index a7db819..ccfb998 100644 >--- a/drivers/net/bonding/bond_main.c >+++ b/drivers/net/bonding/bond_main.c >@@ -1505,7 +1505,6 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev) > slave_dev->npinfo = bond->dev->npinfo; > if (slave_dev->npinfo) { > if (slave_enable_netpoll(new_slave)) { >- read_unlock(&bond->lock); > pr_info("Error, %s: master_dev is using netpoll, " > "but new slave device does not support netpoll.\n", > bond_dev->name); >-- >1.8.0 > >