From: Stephen Hemminger <stephen@networkplumber.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 net-next-for-3.13 2/2] iplink_bond: add support for displaying bond slave attributes
Date: Mon, 10 Feb 2014 12:53:22 -0800 [thread overview]
Message-ID: <20140210125322.1535efc5@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20140210081156.787D5E5697@unicorn.suse.cz>
On Mon, 10 Feb 2014 09:11:56 +0100 (CET)
Michal Kubecek <mkubecek@suse.cz> wrote:
> +static const char *slave_state_tbl[] = {
> + "active",
> + "backup",
> + NULL
> +};
> +
> +static const char *slave_mii_status_tbl[] = {
> + "up",
> + "going_down",
> + "down",
> + "going_back",
> + NULL,
> +};
> +
Is there some correlation of these states to values in a header file.
Something like
static const char *slave_mii_status_tbl[] = {
[BOND_LINK_UP] = "active",
[BOND_LINK_FAIL] = "fail",
[BOND_LINK_DOWN] = "down",
[BOND_LINK_BACK] = "back",
};
And don't use null terminated arrays, use ARRAY_SIZE() instead.
prev parent reply other threads:[~2014-02-10 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 8:11 [PATCH iproute2 net-next-for-3.13 2/2] iplink_bond: add support for displaying bond slave attributes Michal Kubecek
2014-02-10 20:53 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210125322.1535efc5@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox