From: liujunliang_ljl <liujunliang_ljl-9Onoh4P/yGk@public.gmane.org>
To: "Joe Perches" <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: davem <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
horms <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
romieu <romieu-W8zweXLXuWQS+FvcfC7Uqw@public.gmane.org>,
gregkh <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-usb <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
sunhecheng <sunhecheng-i49A8sVr+H5BDgjK7y7TUQ@public.gmane.org>
Subject: Re: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device Driver Support
Date: Mon, 10 Feb 2014 14:32:36 +0800 [thread overview]
Message-ID: <201402101432356252495@163.com> (raw)
In-Reply-To: 1392011221.3178.18.camel@joe-AO722
Dear Joe :
Thanks a lot for your detail checking.
2014-02-10
liujunliang_ljl
发件人： Joe Perches
发送时间： 2014-02-10 13:47:08
收件人： liujunliang_ljl
抄送： davem; horms; romieu; gregkh; netdev; linux-usb; linux-kernel; sunhecheng
主题： Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device Driver Support
On Mon, 2014-02-10 at 13:33 +0800, liujunliang_ljl@163.com wrote:
> diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c
[]
> + netdev_dbg(dev->net, "mac addr : 0x%x:0x%x:0x%x:0x%x:0x%x:0x%x\n",
> + dev->net->dev_addr[0], dev->net->dev_addr[1],
> + dev->net->dev_addr[2], dev->net->dev_addr[3],
> + dev->net->dev_addr[4], dev->net->dev_addr[5]);
mac addresses are assumed to be hex and don't need 0x prefixes.
Also, there's a kernel vsprintf extension "%pM" for mac addresses.
netdev_dbg(dev->net, "mac addr: %pM\n", dev->net->dev_addr);
.
next prev parent reply other threads:[~2014-02-10 6:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 5:33 [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support liujunliang_ljl
[not found] ` <1392010419-5217-1-git-send-email-liujunliang_ljl-9Onoh4P/yGk@public.gmane.org>
2014-02-10 5:47 ` Joe Perches
2014-02-10 6:32 ` liujunliang_ljl [this message]
2014-02-12 10:12 ` Thierry Reding
2014-02-13 4:23 ` Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 DeviceDriver Support liujunliang_ljl
-- strict thread matches above, loose matches on Subject: below --
2014-02-10 6:31 [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support liujunliang_ljl
2014-02-11 0:53 ` David Miller
2014-02-11 5:59 ` Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device " liujunliang_ljl
2014-01-28 8:36 [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device " liujunliang_ljl
2014-01-28 8:59 ` Joe Perches
2014-02-07 3:13 ` Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device " liujunliang_ljl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402101432356252495@163.com \
--to=liujunliang_ljl-9onoh4p/ygk@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=romieu-W8zweXLXuWQS+FvcfC7Uqw@public.gmane.org \
--cc=sunhecheng-i49A8sVr+H5BDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).