From: Thierry Reding <thierry.reding@gmail.com>
To: liujunliang_ljl@163.com
Cc: davem@davemloft.net, horms@verge.net.au, joe@perches.com,
romieu@fr.zoreil.com, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, sunhecheng@vip.126.com
Subject: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support
Date: Wed, 12 Feb 2014 11:12:46 +0100 [thread overview]
Message-ID: <20140212101245.GA3409@ulmo.nvidia.com> (raw)
In-Reply-To: <1392010419-5217-1-git-send-email-liujunliang_ljl@163.com>
[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]
On Mon, Feb 10, 2014 at 01:33:39PM +0800, liujunliang_ljl@163.com wrote:
> From: Liu Junliang <liujunliang_ljl@163.com>
>
>
> Signed-off-by: Liu Junliang <liujunliang_ljl@163.com>
> ---
> drivers/net/usb/Kconfig | 16 +
> drivers/net/usb/Makefile | 1 +
> drivers/net/usb/sr9800.c | 873 ++++++++++++++++++++++++++++++++++++++++++++++
> drivers/net/usb/sr9800.h | 202 +++++++++++
> 4 files changed, 1092 insertions(+), 0 deletions(-)
> create mode 100644 drivers/net/usb/sr9800.c
> create mode 100644 drivers/net/usb/sr9800.h
>
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 47b0f73..2551bf6 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -291,6 +291,22 @@ config USB_NET_SR9700
> This option adds support for CoreChip-sz SR9700 based USB 1.1
> 10/100 Ethernet adapters.
>
> +config USB_NET_SR9800
> + tristate "CoreChip-sz SR9800 based USB 2.0 10/100 ethernet devices"
> + depends on USB_USBNET
> + select CRC32
> + default y
Why is this selected by default? I can see that some of the other USB
network drivers are also selected by default, but not all of them. Is
there some rule of thumb as to which should default to y and which
shouldn't?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-12 10:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 5:33 [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support liujunliang_ljl
[not found] ` <1392010419-5217-1-git-send-email-liujunliang_ljl-9Onoh4P/yGk@public.gmane.org>
2014-02-10 5:47 ` Joe Perches
2014-02-10 6:32 ` Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device " liujunliang_ljl
2014-02-12 10:12 ` Thierry Reding [this message]
2014-02-13 4:23 ` Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 DeviceDriver Support liujunliang_ljl
-- strict thread matches above, loose matches on Subject: below --
2014-02-10 6:31 [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support liujunliang_ljl
2014-02-11 0:53 ` David Miller
2014-02-07 6:42 liujunliang_ljl
2014-02-10 2:08 ` David Miller
2014-02-10 2:58 ` Joe Perches
2014-01-28 8:36 liujunliang_ljl
2014-01-28 8:59 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212101245.GA3409@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liujunliang_ljl@163.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=sunhecheng@vip.126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).