From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Jones Subject: Re: netfilter: nf_tables: add reject module for NFPROTO_INET Date: Wed, 12 Feb 2014 09:18:27 -0500 Message-ID: <20140212141827.GA7129@redhat.com> References: <20140211203359.56ED7660CD3@gitolite.kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kaber@trash.net, pablo@netfilter.org To: netdev@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:35909 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbaBLOSm (ORCPT ); Wed, 12 Feb 2014 09:18:42 -0500 Content-Disposition: inline In-Reply-To: <20140211203359.56ED7660CD3@gitolite.kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Feb 11, 2014 at 08:33:59PM +0000, Linux Kernel wrote: > Gitweb: http://git.kernel.org/linus/;a=commit;h=05513e9e33dbded8124567466a444d32173eecc6 > Commit: 05513e9e33dbded8124567466a444d32173eecc6 > Parent: cc4723ca316742891954efa346298e7c747c0d17 > Author: Patrick McHardy > AuthorDate: Wed Feb 5 15:03:39 2014 +0000 > Committer: Pablo Neira Ayuso > CommitDate: Thu Feb 6 09:44:18 2014 +0100 > > netfilter: nf_tables: add reject module for NFPROTO_INET > > Add a reject module for NFPROTO_INET. It does nothing but dispatch > to the AF-specific modules based on the hook family. > > Signed-off-by: Patrick McHardy > Signed-off-by: Pablo Neira Ayuso > --- .... > +static void nft_reject_inet_eval(const struct nft_expr *expr, > + struct nft_data data[NFT_REG_MAX + 1], > + const struct nft_pktinfo *pkt) > +{ > + switch (pkt->ops->pf) { > + case NFPROTO_IPV4: > + nft_reject_ipv4_eval(expr, data, pkt); > + case NFPROTO_IPV6: > + nft_reject_ipv6_eval(expr, data, pkt); > + } > +} Is the fallthrough intentional here, or is there a missing break ? Dave