From: Patrick McHardy <kaber@trash.net>
To: Dave Jones <davej@redhat.com>
Cc: netdev@vger.kernel.org, pablo@netfilter.org
Subject: Re: netfilter: nf_tables: add reject module for NFPROTO_INET
Date: Wed, 12 Feb 2014 14:27:54 +0000 [thread overview]
Message-ID: <20140212142754.GA303@macbook.localnet> (raw)
In-Reply-To: <20140212141827.GA7129@redhat.com>
On Wed, Feb 12, 2014 at 09:18:27AM -0500, Dave Jones wrote:
> On Tue, Feb 11, 2014 at 08:33:59PM +0000, Linux Kernel wrote:
> > Gitweb: http://git.kernel.org/linus/;a=commit;h=05513e9e33dbded8124567466a444d32173eecc6
> > Commit: 05513e9e33dbded8124567466a444d32173eecc6
> > Parent: cc4723ca316742891954efa346298e7c747c0d17
> > Author: Patrick McHardy <kaber@trash.net>
> > AuthorDate: Wed Feb 5 15:03:39 2014 +0000
> > Committer: Pablo Neira Ayuso <pablo@netfilter.org>
> > CommitDate: Thu Feb 6 09:44:18 2014 +0100
> >
> > netfilter: nf_tables: add reject module for NFPROTO_INET
> >
> > Add a reject module for NFPROTO_INET. It does nothing but dispatch
> > to the AF-specific modules based on the hook family.
> >
> > Signed-off-by: Patrick McHardy <kaber@trash.net>
> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > ---
>
> ....
>
> > +static void nft_reject_inet_eval(const struct nft_expr *expr,
> > + struct nft_data data[NFT_REG_MAX + 1],
> > + const struct nft_pktinfo *pkt)
> > +{
> > + switch (pkt->ops->pf) {
> > + case NFPROTO_IPV4:
> > + nft_reject_ipv4_eval(expr, data, pkt);
> > + case NFPROTO_IPV6:
> > + nft_reject_ipv6_eval(expr, data, pkt);
> > + }
> > +}
>
> Is the fallthrough intentional here, or is there a missing break ?
Crap. Thanks for catching this, I'll send a fix later.
prev parent reply other threads:[~2014-02-12 14:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140211203359.56ED7660CD3@gitolite.kernel.org>
2014-02-12 14:18 ` netfilter: nf_tables: add reject module for NFPROTO_INET Dave Jones
2014-02-12 14:27 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212142754.GA303@macbook.localnet \
--to=kaber@trash.net \
--cc=davej@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).