* Re: netfilter: nf_tables: add reject module for NFPROTO_INET
[not found] <20140211203359.56ED7660CD3@gitolite.kernel.org>
@ 2014-02-12 14:18 ` Dave Jones
2014-02-12 14:27 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2014-02-12 14:18 UTC (permalink / raw)
To: netdev; +Cc: kaber, pablo
On Tue, Feb 11, 2014 at 08:33:59PM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=05513e9e33dbded8124567466a444d32173eecc6
> Commit: 05513e9e33dbded8124567466a444d32173eecc6
> Parent: cc4723ca316742891954efa346298e7c747c0d17
> Author: Patrick McHardy <kaber@trash.net>
> AuthorDate: Wed Feb 5 15:03:39 2014 +0000
> Committer: Pablo Neira Ayuso <pablo@netfilter.org>
> CommitDate: Thu Feb 6 09:44:18 2014 +0100
>
> netfilter: nf_tables: add reject module for NFPROTO_INET
>
> Add a reject module for NFPROTO_INET. It does nothing but dispatch
> to the AF-specific modules based on the hook family.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
....
> +static void nft_reject_inet_eval(const struct nft_expr *expr,
> + struct nft_data data[NFT_REG_MAX + 1],
> + const struct nft_pktinfo *pkt)
> +{
> + switch (pkt->ops->pf) {
> + case NFPROTO_IPV4:
> + nft_reject_ipv4_eval(expr, data, pkt);
> + case NFPROTO_IPV6:
> + nft_reject_ipv6_eval(expr, data, pkt);
> + }
> +}
Is the fallthrough intentional here, or is there a missing break ?
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: netfilter: nf_tables: add reject module for NFPROTO_INET
2014-02-12 14:18 ` netfilter: nf_tables: add reject module for NFPROTO_INET Dave Jones
@ 2014-02-12 14:27 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2014-02-12 14:27 UTC (permalink / raw)
To: Dave Jones; +Cc: netdev, pablo
On Wed, Feb 12, 2014 at 09:18:27AM -0500, Dave Jones wrote:
> On Tue, Feb 11, 2014 at 08:33:59PM +0000, Linux Kernel wrote:
> > Gitweb: http://git.kernel.org/linus/;a=commit;h=05513e9e33dbded8124567466a444d32173eecc6
> > Commit: 05513e9e33dbded8124567466a444d32173eecc6
> > Parent: cc4723ca316742891954efa346298e7c747c0d17
> > Author: Patrick McHardy <kaber@trash.net>
> > AuthorDate: Wed Feb 5 15:03:39 2014 +0000
> > Committer: Pablo Neira Ayuso <pablo@netfilter.org>
> > CommitDate: Thu Feb 6 09:44:18 2014 +0100
> >
> > netfilter: nf_tables: add reject module for NFPROTO_INET
> >
> > Add a reject module for NFPROTO_INET. It does nothing but dispatch
> > to the AF-specific modules based on the hook family.
> >
> > Signed-off-by: Patrick McHardy <kaber@trash.net>
> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > ---
>
> ....
>
> > +static void nft_reject_inet_eval(const struct nft_expr *expr,
> > + struct nft_data data[NFT_REG_MAX + 1],
> > + const struct nft_pktinfo *pkt)
> > +{
> > + switch (pkt->ops->pf) {
> > + case NFPROTO_IPV4:
> > + nft_reject_ipv4_eval(expr, data, pkt);
> > + case NFPROTO_IPV6:
> > + nft_reject_ipv6_eval(expr, data, pkt);
> > + }
> > +}
>
> Is the fallthrough intentional here, or is there a missing break ?
Crap. Thanks for catching this, I'll send a fix later.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-12 14:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140211203359.56ED7660CD3@gitolite.kernel.org>
2014-02-12 14:18 ` netfilter: nf_tables: add reject module for NFPROTO_INET Dave Jones
2014-02-12 14:27 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).