From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: arp: process only if ipv4 address configured
Date: Wed, 12 Feb 2014 23:01:43 +0100 [thread overview]
Message-ID: <20140212220143.GD25153@breakpoint.cc> (raw)
In-Reply-To: <1392229587.1752.11.camel@edumazet-glaptop2.roam.corp.google.com>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Wed, 2014-02-12 at 18:27 +0100, Florian Westphal wrote:
> > 8030f54499925d073a88c09f ([IPV4] devinet: Register inetdev earlier.)
> > changed arp behaviour (2.6.22 onwards).
> >
> > Before this, inetdev_init() was called only when the first address was
> > added to the interface, i.e. arp_process always dropped incoming arp
> > packets as __in_dev_get_rcu() returned NULL when no IP address was set
> > on the interface.
> >
> > With >= 2.6.22 we now process arp packets even if no address is assigned.
> > It can cause issues if the machine has several interfaces in the same
> > segment; requests receive answers from multiple macs.
>
> What about arp_filter value/meaning ?
Sure, arp_filter=1 avoids this.
If you mean "we don't care, its been like this for years and if you
don't want it then set arp_filter=1" -- fine with me.
Sorry if this wasn't clear -- its more about the change in behaviour
and if we should care.
next prev parent reply other threads:[~2014-02-12 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 17:27 [PATCH] ipv4: arp: process only if ipv4 address configured Florian Westphal
2014-02-12 18:26 ` Eric Dumazet
2014-02-12 22:01 ` Florian Westphal [this message]
2014-02-13 0:24 ` Hannes Frederic Sowa
2014-02-13 0:25 ` David Miller
2014-02-13 8:56 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212220143.GD25153@breakpoint.cc \
--to=fw@strlen.de \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).