From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: core: introduce netif_skb_dev_features
Date: Thu, 13 Feb 2014 15:43:47 -0500 (EST) [thread overview]
Message-ID: <20140213.154347.1868967252351926699.davem@davemloft.net> (raw)
In-Reply-To: <1392064537-30646-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Mon, 10 Feb 2014 21:35:36 +0100
> @@ -2495,34 +2495,36 @@ static int dev_gso_segment(struct sk_buff *skb, netdev_features_t features)
> }
>
> static netdev_features_t harmonize_features(struct sk_buff *skb,
> - netdev_features_t features)
> + const struct net_device *dev,
> + netdev_features_t features)
...
> - } else if (illegal_highdma(skb->dev, skb)) {
> + } else if (illegal_highdma(dev, skb)) {
illegal_highdma() is not prepared to take a "const struct net_device *",
you must have seen the warning in your build. At least I did.
Please fix this and resubmit this series, thanks.
prev parent reply other threads:[~2014-02-13 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 20:35 [PATCH 1/2] net: core: introduce netif_skb_dev_features Florian Westphal
2014-02-10 20:35 ` [PATCH v5 2/2] net: ip, ipv6: handle gso skbs in forwarding path Florian Westphal
2014-02-11 13:14 ` Herbert Xu
2014-02-13 20:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213.154347.1868967252351926699.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox