From: Simon Horman <horms@verge.net.au>
To: Andi Kleen <ak@linux.intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Wensong Zhang <wensong@linux-vs.org>,
Patrick McHardy <kaber@trash.net>,
lvs-devel@vger.kernel.org
Subject: Re: [PATCH] sections, ipvs: Remove useless __read_mostly for ipvs genl_ops
Date: Thu, 13 Feb 2014 16:05:38 +0900 [thread overview]
Message-ID: <20140213070538.GA11245@verge.net.au> (raw)
In-Reply-To: <1391846221-30240-1-git-send-email-ak@linux.intel.com>
On Sat, Feb 08, 2014 at 08:57:01AM +0100, Andi Kleen wrote:
> const __read_mostly does not make any sense, because const
> data is already read-only. Remove the __read_mostly
> for the ipvs genl_ops. This avoids a LTO
> section conflict compile problem.
Thanks Andi, applied to ipvs-next.
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Patrick McHardy <kaber@trash.net>
> Cc: lvs-devel@vger.kernel.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> net/netfilter/ipvs/ip_vs_ctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index 35be035..2a68a38 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -3580,7 +3580,7 @@ out:
> }
>
>
> -static const struct genl_ops ip_vs_genl_ops[] __read_mostly = {
> +static const struct genl_ops ip_vs_genl_ops[] = {
> {
> .cmd = IPVS_CMD_NEW_SERVICE,
> .flags = GENL_ADMIN_PERM,
> --
> 1.8.5.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-02-13 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 7:57 [PATCH] sections, ipvs: Remove useless __read_mostly for ipvs genl_ops Andi Kleen
2014-02-13 7:05 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213070538.GA11245@verge.net.au \
--to=horms@verge.net.au \
--cc=ak@linux.intel.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).