From: David Miller <davem@davemloft.net>
To: emilgoode@gmail.com
Cc: ming.lei@canonical.com, broonie@linaro.org,
jeffrey.t.kirsher@intel.com, gdt@gdt.id.au,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH Resend] net: asix: add missing flag to struct driver_info
Date: Fri, 14 Feb 2014 15:48:53 -0500 (EST) [thread overview]
Message-ID: <20140214.154853.1291869116525546930.davem@davemloft.net> (raw)
In-Reply-To: <1392316239-17335-1-git-send-email-emilgoode@gmail.com>
From: Emil Goode <emilgoode@gmail.com>
Date: Thu, 13 Feb 2014 19:30:39 +0100
> The struct driver_info ax88178_info is assigned the function
> asix_rx_fixup_common as it's rx_fixup callback. This means that
> FLAG_MULTI_PACKET must be set as this function is cloning the
> data and calling usbnet_skb_return. Not setting this flag leads
> to usbnet_skb_return beeing called a second time from within
> the rx_process function in the usbnet module.
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> Reported-by: Bjørn Mork <bjorn@mork.no>
Applied and queued up for -stable.
It would be great if there were some way to validate these
callback flags requirements and catch such errors.
prev parent reply other threads:[~2014-02-14 20:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 18:30 [PATCH Resend] net: asix: add missing flag to struct driver_info Emil Goode
2014-02-14 20:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214.154853.1291869116525546930.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=broonie@linaro.org \
--cc=emilgoode@gmail.com \
--cc=gdt@gdt.id.au \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox