* [PATCH] Fix Default to 'y' for SR9800 Device Driver, setting to 'n'
@ 2014-02-13 4:22 liujunliang_ljl
2014-02-13 23:32 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: liujunliang_ljl @ 2014-02-13 4:22 UTC (permalink / raw)
To: thierry.reding
Cc: davem, horms, joe, romieu, gregkh, netdev, linux-usb,
linux-kernel, sunhecheng, Liu Junliang
From: Liu Junliang <liujunliang_ljl@163.com>
Signed-off-by: Liu Junliang <liujunliang_ljl@163.com>
---
drivers/net/usb/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 2551bf6..82df7c3 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -295,7 +295,6 @@ config USB_NET_SR9800
tristate "CoreChip-sz SR9800 based USB 2.0 10/100 ethernet devices"
depends on USB_USBNET
select CRC32
- default y
---help---
Say Y if you want to use one of the following 100Mbps USB Ethernet
device based on the CoreChip-sz SR9800 chip.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix Default to 'y' for SR9800 Device Driver, setting to 'n'
2014-02-13 4:22 [PATCH] Fix Default to 'y' for SR9800 Device Driver, setting to 'n' liujunliang_ljl
@ 2014-02-13 23:32 ` David Miller
2014-02-14 0:38 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2014-02-13 23:32 UTC (permalink / raw)
To: liujunliang_ljl
Cc: thierry.reding, horms, joe, romieu, gregkh, netdev, linux-usb,
linux-kernel, sunhecheng
From: liujunliang_ljl@163.com
Date: Thu, 13 Feb 2014 12:22:19 +0800
> From: Liu Junliang <liujunliang_ljl@163.com>
>
>
> Signed-off-by: Liu Junliang <liujunliang_ljl@163.com>
I think it's more canonical to specify no default at all.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix Default to 'y' for SR9800 Device Driver, setting to 'n'
2014-02-13 23:32 ` David Miller
@ 2014-02-14 0:38 ` Sergei Shtylyov
2014-02-13 23:42 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2014-02-14 0:38 UTC (permalink / raw)
To: David Miller, liujunliang_ljl
Cc: thierry.reding, horms, joe, romieu, gregkh, netdev, linux-usb,
linux-kernel, sunhecheng
Hello.
On 02/14/2014 02:32 AM, David Miller wrote:
>> From: Liu Junliang <liujunliang_ljl@163.com>
>> Signed-off-by: Liu Junliang <liujunliang_ljl@163.com>
> I think it's more canonical to specify no default at all.
That's what he did, no?
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fix Default to 'y' for SR9800 Device Driver, setting to 'n'
2014-02-14 0:38 ` Sergei Shtylyov
@ 2014-02-13 23:42 ` David Miller
2014-02-14 6:43 ` Re: [PATCH] Fix Default to 'y' for SR9800 Device Driver, settingto 'n' liujunliang_ljl
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2014-02-13 23:42 UTC (permalink / raw)
To: sergei.shtylyov
Cc: liujunliang_ljl, thierry.reding, horms, joe, romieu, gregkh,
netdev, linux-usb, linux-kernel, sunhecheng
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 14 Feb 2014 03:38:17 +0300
> Hello.
>
> On 02/14/2014 02:32 AM, David Miller wrote:
>
>>> From: Liu Junliang <liujunliang_ljl@163.com>
>
>>> Signed-off-by: Liu Junliang <liujunliang_ljl@163.com>
>
>> I think it's more canonical to specify no default at all.
>
> That's what he did, no?
Indeed, my bad, patch applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Re: [PATCH] Fix Default to 'y' for SR9800 Device Driver, settingto 'n'
2014-02-13 23:42 ` David Miller
@ 2014-02-14 6:43 ` liujunliang_ljl
0 siblings, 0 replies; 5+ messages in thread
From: liujunliang_ljl @ 2014-02-14 6:43 UTC (permalink / raw)
To: David Miller, sergei.shtylyov
Cc: thierry.reding, horms, joe, romieu, gregkh, netdev, linux-usb,
linux-kernel, sunhecheng
Dear David :
Thanks all the same.
2014-02-14
liujunliang_ljl
发件人： David Miller
发送时间： 2014-02-14 07:42:24
收件人： sergei.shtylyov
抄送： liujunliang_ljl; thierry.reding; horms; joe; romieu; gregkh; netdev; linux-usb; linux-kernel; sunhecheng
主题： Re: [PATCH] Fix Default to 'y' for SR9800 Device Driver, settingto 'n'
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 14 Feb 2014 03:38:17 +0300
> Hello.
>
> On 02/14/2014 02:32 AM, David Miller wrote:
>
>>> From: Liu Junliang <liujunliang_ljl@163.com>
>
>>> Signed-off-by: Liu Junliang <liujunliang_ljl@163.com>
>
>> I think it's more canonical to specify no default at all.
>
> That's what he did, no?
Indeed, my bad, patch applied, thanks!
.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-14 6:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-13 4:22 [PATCH] Fix Default to 'y' for SR9800 Device Driver, setting to 'n' liujunliang_ljl
2014-02-13 23:32 ` David Miller
2014-02-14 0:38 ` Sergei Shtylyov
2014-02-13 23:42 ` David Miller
2014-02-14 6:43 ` Re: [PATCH] Fix Default to 'y' for SR9800 Device Driver, settingto 'n' liujunliang_ljl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).