From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: sesse@samfundet.no, hannes@stressinduktion.org,
itk-intern@samfundet.no, netdev@vger.kernel.org
Subject: Re: [PATCH net] gre: add link local route when local addr is any
Date: Mon, 17 Feb 2014 14:09:20 -0500 (EST) [thread overview]
Message-ID: <20140217.140920.2121605616455173237.davem@davemloft.net> (raw)
In-Reply-To: <1392643341-4288-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Mon, 17 Feb 2014 14:22:21 +0100
> This bug was reported by Steinar H. Gunderson and was introduced by commit
> f7cb8886335d ("sit/gre6: don't try to add the same route two times").
>
> root@morgental:~# ip tunnel add foo mode gre remote 1.2.3.4 ttl 64
> root@morgental:~# ip link set foo up mtu 1468
> root@morgental:~# ip -6 route show dev foo
> fe80::/64 proto kernel metric 256
>
> but after the above commit, no such route shows up.
>
> There is no link local route because dev->dev_addr is 0 (because local ipv4
> address is 0), hence no link local address is configured.
>
> In this scenario, the link local address is added manually: 'ip -6 addr add
> fe80::1 dev foo' and because prefix is /128, no link local route is added by the
> kernel.
>
> Even if the right things to do is to add the link local address with a /64
> prefix, we need to restore the previous behavior to avoid breaking userpace.
>
> Reported-by: Steinar H. Gunderson <sesse@samfundet.no>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2014-02-17 19:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 21:55 fe80::/64 route missing on GRE tunnels Steinar H. Gunderson
2014-02-11 21:59 ` Steinar H. Gunderson
2014-02-15 7:45 ` Hannes Frederic Sowa
2014-02-15 12:10 ` Hannes Frederic Sowa
2014-02-17 9:37 ` Nicolas Dichtel
2014-02-17 9:45 ` Steinar H. Gunderson
2014-02-17 9:59 ` Nicolas Dichtel
2014-02-17 10:17 ` Steinar H. Gunderson
2014-02-17 10:34 ` Nicolas Dichtel
2014-02-17 13:04 ` Hannes Frederic Sowa
2014-02-17 13:22 ` [PATCH net] gre: add link local route when local addr is any Nicolas Dichtel
2014-02-17 19:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217.140920.2121605616455173237.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=itk-intern@samfundet.no \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=sesse@samfundet.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).