netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: David Miller <davem@davemloft.net>
Cc: fw@strlen.de, netdev@vger.kernel.org, ncardwell@google.com,
	eric.dumazet@gmail.com, ycheng@google.com
Subject: Re: [PATCH next resend] tcp: use zero-window when free_space is low
Date: Mon, 17 Feb 2014 21:52:19 +0100	[thread overview]
Message-ID: <20140217205219.GH31125@breakpoint.cc> (raw)
In-Reply-To: <20140217.143431.349062553619161172.davem@davemloft.net>

David Miller <davem@davemloft.net> wrote:
> From: Florian Westphal <fw@strlen.de>
> Date: Thu, 13 Feb 2014 12:52:30 +0100
> 
> >  V1 of this patch was deferred, resending to get discussion going again.
> >  Changes since v1:
> >   - add reproducer to commit message
> > 
> >  Unfortunately I couldn't come up with something that has no magic
> >  ('allowed >> 4') value.  I chose >>4 (1/16th) because it didn't cause
> >  tput limitations in my 'full-mss-sized, steady state' netcat tests.
> > 
> >  Maybe someone has better idea?
> 
> I know this is going to be frustrating, but I've marked this 'deferred'
> again.  Please resubmit after the testing and further discussions have
> been worked out.

Thanks for letting me know.  I understand why you are reluctant to just
apply this.

I will submit another patch shortly that introduces snmp counter for zero-window
(what Eric suggested), perhaps it helps him or others to find a better solution
in the scenario.

  reply	other threads:[~2014-02-17 20:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 11:52 [PATCH next resend] tcp: use zero-window when free_space is low Florian Westphal
2014-02-13 14:58 ` Eric Dumazet
2014-02-13 15:34   ` Florian Westphal
2014-02-13 16:19     ` Eric Dumazet
2014-02-13 17:18 ` Rick Jones
2014-02-17 19:34 ` David Miller
2014-02-17 20:52   ` Florian Westphal [this message]
2014-02-18 17:30     ` Eric Dumazet
2014-02-18 23:12       ` Eric Dumazet
2014-02-19 21:36         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140217205219.GH31125@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).