From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Tommie Gannert <tommie@gannert.se>
Cc: Samuel Ortiz <samuel@sortiz.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] irtty-sir.c: Do not set_termios() on irtty_close()
Date: Mon, 17 Feb 2014 23:13:19 +0000 [thread overview]
Message-ID: <20140217231319.5545dac1@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <5302750C.6080407@gannert.se>
> v2: Resend due to mail format issues. More Thunderbird settings applied.
>
> I know very little of this code, and I'm not sure this is a good solution,
> so here's some background:
I wouldn't worry too much. I'm amazed the code even works these days.
It's incredibly bitrotted and doesn't use the tty layer properly (mind
you it never did)
> The effect of this is that /dev/ttyUSB* is still in use, and thus leaking
> at least dev nodes. This is a minimal patch that solves that oops.
> --- linux-3.12/drivers/net/irda/irtty-sir.c.orig 2014-02-12 21:36:46.132496089 +0000
> +++ linux-3.12/drivers/net/irda/irtty-sir.c 2014-02-12 21:57:21.635843884 +0000
> @@ -521,7 +521,6 @@ static void irtty_close(struct tty_struc
> sirdev_put_instance(priv->dev);
>
> /* Stop tty */
> - irtty_stop_receiver(tty, TRUE);
> clear_bit(TTY_DO_WRITE_WAKEUP, &tty->flags);
> if (tty->ops->stop)
> tty->ops->stop(tty);
This change looks correct to me. The three lines below your change are
amusing all incorrect and should probably also all be deleted.
Alan
prev parent reply other threads:[~2014-02-17 23:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 8:52 [PATCH] irtty-sir.c: Do not set_termios() on irtty_close() Tommie Gannert
2014-02-17 19:29 ` David Miller
2014-02-17 20:46 ` [PATCHv2] " Tommie Gannert
2014-02-17 21:28 ` David Miller
2014-02-17 23:13 ` One Thousand Gnomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217231319.5545dac1@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
--cc=tommie@gannert.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).