Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: christoph.paasch@uclouvain.be
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net,
	jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
	carolyn.wyborny@intel.com
Subject: Re: [PATCH net] igb: Fix Null-pointer dereference in igb_reset_q_vector
Date: Tue, 18 Feb 2014 18:08:08 -0500 (EST)	[thread overview]
Message-ID: <20140218.180808.558822435914770314.davem@davemloft.net> (raw)
In-Reply-To: <1392728817-21693-1-git-send-email-christoph.paasch@uclouvain.be>

From: Christoph Paasch <christoph.paasch@uclouvain.be>
Date: Tue, 18 Feb 2014 14:06:57 +0100

> When igb_set_interrupt_capability() calls
> igb_reset_interrupt_capability() (e.g., because CONFIG_PCI_MSI is unset),
> num_q_vectors has been set but no vector has yet been allocated.
> 
> igb_reset_interrupt_capability() will then call igb_reset_q_vector,
> which assumes that the vector is allocated. As this is not the case, we
> are accessing a NULL-pointer.
> 
> This patch fixes it by checking that q_vector is indeed different from
> NULL.
> 
> Fixes: 02ef6e1d0b0023 (igb: Fix queue allocation method to accommodate changing during runtime)
> Cc: Carolyn Wyborny <carolyn.wyborny@intel.com>
> Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>

Intel folks, please queue this up, thanks.

  reply	other threads:[~2014-02-18 23:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 13:06 [PATCH net] igb: Fix Null-pointer dereference in igb_reset_q_vector Christoph Paasch
2014-02-18 23:08 ` David Miller [this message]
2014-02-18 23:57 ` Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140218.180808.558822435914770314.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=carolyn.wyborny@intel.com \
    --cc=christoph.paasch@uclouvain.be \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox