From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: ethernet: remove unneeded dependency of mvneta and update help text
Date: Tue, 18 Feb 2014 16:51:28 +0100 [thread overview]
Message-ID: <20140218165128.5535a9ef@skate> (raw)
In-Reply-To: <20140218154512.GA10691@localhost>
Dear Ezequiel Garcia,
On Tue, 18 Feb 2014 12:45:12 -0300, Ezequiel Garcia wrote:
> > At the very end of the clean up, when even Orion5x support will be
> > merged in mach-mvebu/, then we can certainly replace these dependencies
> > by a "depends on ARCH_MVEBU". But for the time being, PLAT_ORION seems
> > like the right common denominator for all these platforms.
> >
>
> Last time we talked about this with Sebastian and Andrew it was decided
> that the right choice is:
>
> MACH_KIRKWOOD || MACH_DOVE || MACH_ARMADA_370_XP
And why not Orion5x and MV78xx0 ?
>
> Which would become MACH_MVEBU.
>
> Of course, this is near the nitpick boundary, so AFAIC you can leave
> PLAT_ORION as in v2, if you feel like.
As I suggested previously, PLAT_ORION is what *today* controls the
visibility of all Marvell EBU drivers. Please grep for PLAT_ORION in
your kernel tree. So why on earth would we invent something completely
different for mvneta?
When tomorrow ARCH_MVEBU will be used for all mvebu platforms, then
indeed PLAT_ORION can be changed to ARCH_MVEBU.
Your suggestion above to use MACH_ARMADA_370_XP is *precisely* what
this patch is removing, because MACH_ARMADA_370_XP is being removed
from arch/arm/mach-mvebu/.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-18 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 10:29 [PATCH] net: ethernet: remove unneeded dependency of mvneta and update help text Thomas Petazzoni
2014-02-18 12:29 ` Jason Cooper
2014-02-18 12:45 ` Thomas Petazzoni
2014-02-18 12:52 ` Jason Cooper
2014-02-18 13:13 ` Thomas Petazzoni
2014-02-18 13:58 ` Andrew Lunn
2014-02-18 14:10 ` Thomas Petazzoni
2014-02-18 15:45 ` Ezequiel Garcia
2014-02-18 15:51 ` Thomas Petazzoni [this message]
2014-02-18 17:23 ` Ezequiel Garcia
2014-02-19 2:10 ` Jisheng Zhang
2014-02-19 8:08 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218165128.5535a9ef@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).