From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH] net: ethernet: remove unneeded dependency of mvneta and update help text Date: Tue, 18 Feb 2014 16:51:28 +0100 Message-ID: <20140218165128.5535a9ef@skate> References: <1392719391-8851-1-git-send-email-thomas.petazzoni@free-electrons.com> <20140218122952.GM7862@titan.lakedaemon.net> <20140218134532.7607a616@skate> <20140218125206.GN7862@titan.lakedaemon.net> <20140218141303.77c77272@skate> <20140218135809.GD17984@lunn.ch> <20140218151027.710ab2f3@skate> <20140218154512.GA10691@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , Jason Cooper , "David S. Miller" , netdev@vger.kernel.org, Gregory Clement , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org To: Ezequiel Garcia Return-path: Received: from top.free-electrons.com ([176.31.233.9]:46405 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755593AbaBRPvb (ORCPT ); Tue, 18 Feb 2014 10:51:31 -0500 In-Reply-To: <20140218154512.GA10691@localhost> Sender: netdev-owner@vger.kernel.org List-ID: Dear Ezequiel Garcia, On Tue, 18 Feb 2014 12:45:12 -0300, Ezequiel Garcia wrote: > > At the very end of the clean up, when even Orion5x support will be > > merged in mach-mvebu/, then we can certainly replace these dependencies > > by a "depends on ARCH_MVEBU". But for the time being, PLAT_ORION seems > > like the right common denominator for all these platforms. > > > > Last time we talked about this with Sebastian and Andrew it was decided > that the right choice is: > > MACH_KIRKWOOD || MACH_DOVE || MACH_ARMADA_370_XP And why not Orion5x and MV78xx0 ? > > Which would become MACH_MVEBU. > > Of course, this is near the nitpick boundary, so AFAIC you can leave > PLAT_ORION as in v2, if you feel like. As I suggested previously, PLAT_ORION is what *today* controls the visibility of all Marvell EBU drivers. Please grep for PLAT_ORION in your kernel tree. So why on earth would we invent something completely different for mvneta? When tomorrow ARCH_MVEBU will be used for all mvebu platforms, then indeed PLAT_ORION can be changed to ARCH_MVEBU. Your suggestion above to use MACH_ARMADA_370_XP is *precisely* what this patch is removing, because MACH_ARMADA_370_XP is being removed from arch/arm/mach-mvebu/. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com