From: David Miller <davem@davemloft.net>
To: erik.hugne@ericsson.com
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
ying.xue@windriver.com, paul.gortmaker@windriver.com,
jon.maloy@ericsson.com, maloy@donjonn.com
Subject: Re: [PATCH net-next v2] tipc: failed transmissions should return error
Date: Wed, 19 Feb 2014 16:41:10 -0500 (EST) [thread overview]
Message-ID: <20140219.164110.1433043026929645851.davem@davemloft.net> (raw)
In-Reply-To: <1392795478-13434-1-git-send-email-erik.hugne@ericsson.com>
From: <erik.hugne@ericsson.com>
Date: Wed, 19 Feb 2014 08:37:58 +0100
> From: Erik Hugne <erik.hugne@ericsson.com>
>
> When a message could not be sent out because the destination node
> or link could not be found, the full message size is returned from
> sendmsg() as if it had been sent successfully. An application will
> then get a false indication that it's making forward progress. This
> problem has existed since the initial commit in 2.6.16.
>
> We change this to return -ENETUNREACH if the message cannot be
> delivered due to the destination node/link being unavailable. We
> also get rid of the redundant tipc_reject_msg call since freeing
> the buffer and doing a tipc_port_iovec_reject accomplishes exactly
> the same thing.
>
> Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
> Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
Applied, thank you.
prev parent reply other threads:[~2014-02-19 21:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 7:37 [PATCH net-next v2] tipc: failed transmissions should return error erik.hugne
2014-02-19 21:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219.164110.1433043026929645851.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).