From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2] tipc: failed transmissions should return error Date: Wed, 19 Feb 2014 16:41:10 -0500 (EST) Message-ID: <20140219.164110.1433043026929645851.davem@davemloft.net> References: <1392795478-13434-1-git-send-email-erik.hugne@ericsson.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, ying.xue@windriver.com, paul.gortmaker@windriver.com, jon.maloy@ericsson.com, maloy@donjonn.com To: erik.hugne@ericsson.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:47043 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752516AbaBSVlM (ORCPT ); Wed, 19 Feb 2014 16:41:12 -0500 In-Reply-To: <1392795478-13434-1-git-send-email-erik.hugne@ericsson.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Date: Wed, 19 Feb 2014 08:37:58 +0100 > From: Erik Hugne > > When a message could not be sent out because the destination node > or link could not be found, the full message size is returned from > sendmsg() as if it had been sent successfully. An application will > then get a false indication that it's making forward progress. This > problem has existed since the initial commit in 2.6.16. > > We change this to return -ENETUNREACH if the message cannot be > delivered due to the destination node/link being unavailable. We > also get rid of the redundant tipc_reject_msg call since freeing > the buffer and doing a tipc_port_iovec_reject accomplishes exactly > the same thing. > > Signed-off-by: Erik Hugne > Reviewed-by: Jon Maloy Applied, thank you.