From: David Miller <davem@davemloft.net>
To: jiang.biao2@zte.com.cn
Cc: netdev@vger.kernel.org, sathya.perla@emulex.com,
subbu.seetharaman@emulex.com, ajit.khaparde@emulex.com,
wang.liang82@zte.com.cn, cai.qu@zte.com.cn,
li.fengmao@zte.com.cn, long.chun@zte.com.cn
Subject: Re: [PATCH] be2net: Bugfix for packet drop with kernel param swiotlb=force
Date: Wed, 19 Feb 2014 16:44:16 -0500 (EST) [thread overview]
Message-ID: <20140219.164416.129376508868063340.davem@davemloft.net> (raw)
In-Reply-To: <OF433C3BAF.359D84C5-ON48257C84.002D80B1-48257C84.002E4C8C@zte.com.cn>
From: jiang.biao2@zte.com.cn
Date: Wed, 19 Feb 2014 16:25:40 +0800
> + dma_unmap_page(&adapter->pdev->dev,
> + dma_unmap_addr(rx_page_info, bus),
> + rx_frag_size, DMA_FROM_DEVICE);
This is not indented properly.
Arguments on the second and subsequent lines of a function call must
start exactly at the first column after the openning parenthesis of the
function call on the first line.
You must use the appropriate number of TAB and SPACE characters
necessary to do so.
If you are indenting only using TAB characters, you are doing it wrong.
next prev parent reply other threads:[~2014-02-19 21:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 8:25 [PATCH] be2net: Bugfix for packet drop with kernel param swiotlb=force jiang.biao2
2014-02-19 21:44 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-20 1:56 jiang.biao2
2014-02-20 9:39 ` Sathya Perla
2014-02-22 1:49 ` Ben Hutchings
2014-02-24 6:43 ` Sathya Perla
2014-02-25 14:06 ` Sathya Perla
2014-02-25 16:58 ` Ben Hutchings
2014-02-26 4:54 ` Sathya Perla
2014-03-01 1:00 ` Ben Hutchings
2014-03-03 7:24 ` Sathya Perla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219.164416.129376508868063340.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@emulex.com \
--cc=cai.qu@zte.com.cn \
--cc=jiang.biao2@zte.com.cn \
--cc=li.fengmao@zte.com.cn \
--cc=long.chun@zte.com.cn \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
--cc=subbu.seetharaman@emulex.com \
--cc=wang.liang82@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).